Skip to content

ROX-31774: Fix Listening Endpoints Page#18156

Merged
sachaudh merged 3 commits intodv/ROX-28622-pf-6from
sc/ROX-31774
Dec 12, 2025
Merged

ROX-31774: Fix Listening Endpoints Page#18156
sachaudh merged 3 commits intodv/ROX-28622-pf-6from
sc/ROX-31774

Conversation

@sachaudh
Copy link
Contributor

@sachaudh sachaudh commented Dec 9, 2025

Description

Fixes layout and styling issues on Listening Endpoints page:

  • Fixed toolbar layout by moving entity filter into proper filter group and separating pagination with toolbar separator
  • Fixed page section padding/variants to match PatternFly standards - removed custom flexbox classes, used padding={{ default: 'noPadding' }} for content area
  • Added CSS rule for .pf-v6-c-page__main-container to ensure proper full-height rendering
  • Increased default page size from 10 to 20 items

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the
    functionality is gated by a feature flag
  • CI results are
    inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

UI-only changes verified manually:

  • Toolbar renders correctly with proper filter grouping and pagination alignment
  • Page sections display properly without layout overflow issues
  • Empty states and loading states render as expected
  • Search and filtering work correctly

Before
Screenshot 2025-12-09 at 2 31 58 PM

After
Screenshot 2025-12-09 at 3 16 08 PM

Tests passing
Screenshot 2025-12-09 at 3 12 44 PM

@openshift-ci
Copy link

openshift-ci bot commented Dec 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.34%. Comparing base (31f3270) to head (9ecb568).
⚠️ Report is 2 commits behind head on dv/ROX-28622-pf-6.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           dv/ROX-28622-pf-6   #18156      +/-   ##
=====================================================
- Coverage              49.34%   49.34%   -0.01%     
=====================================================
  Files                   2719     2719              
  Lines                 200699   200699              
=====================================================
- Hits                   99043    99033      -10     
- Misses                 94003    94010       +7     
- Partials                7653     7656       +3     
Flag Coverage Δ
go-unit-tests 49.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sachaudh sachaudh marked this pull request as ready for review December 9, 2025 23:26
@sachaudh sachaudh requested a review from a team as a code owner December 9, 2025 23:26
@dvail dvail force-pushed the dv/ROX-28622-pf-6 branch from 674d509 to 31f3270 Compare December 9, 2025 23:30
@dvail dvail requested a review from a team as a code owner December 9, 2025 23:30
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
@sachaudh sachaudh added the pls-merge Indicates to the *reviewer* that the PR can be merged once tests pass and approval is granted label Dec 12, 2025
@sachaudh sachaudh merged commit ecace39 into dv/ROX-28622-pf-6 Dec 12, 2025
64 of 69 checks passed
@sachaudh sachaudh deleted the sc/ROX-31774 branch December 12, 2025 22:51
@sachaudh sachaudh added pf-v6-upgrade and removed pls-merge Indicates to the *reviewer* that the PR can be merged once tests pass and approval is granted labels Jan 7, 2026
dvail pushed a commit that referenced this pull request Jan 7, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail pushed a commit that referenced this pull request Jan 30, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail pushed a commit that referenced this pull request Feb 3, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail pushed a commit that referenced this pull request Feb 6, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail pushed a commit that referenced this pull request Feb 10, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail pushed a commit that referenced this pull request Feb 11, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail pushed a commit that referenced this pull request Feb 12, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail pushed a commit that referenced this pull request Feb 13, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants