ROX-31775: Fix Violations Page issues for v6 upgrade#18194
Merged
sachaudh merged 9 commits intodv/ROX-28622-pf-6from Jan 2, 2026
Merged
ROX-31775: Fix Violations Page issues for v6 upgrade#18194sachaudh merged 9 commits intodv/ROX-28622-pf-6from
sachaudh merged 9 commits intodv/ROX-28622-pf-6from
Conversation
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
|
Skipping CI for Draft Pull Request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dv/ROX-28622-pf-6 #18194 +/- ##
=====================================================
- Coverage 49.34% 49.34% -0.01%
=====================================================
Files 2719 2719
Lines 200699 200699
=====================================================
- Hits 99043 99030 -13
- Misses 94003 94012 +9
- Partials 7653 7657 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
2345575 to
a2653d7
Compare
dvail
approved these changes
Dec 16, 2025
Contributor
dvail
left a comment
There was a problem hiding this comment.
Reviewed before I realized that this was still in draft, but overall LGTM.
I think we should rebase and move the pf6 selectors to a common location but the approach overall is ready to go.
ui/apps/platform/cypress/integration/violations/Violations.selectors.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Sweet, thanks for the review!
Yes, that sounds like a good idea. Makes it easier to test 👍🏼 |
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail
pushed a commit
that referenced
this pull request
Jan 7, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail
pushed a commit
that referenced
this pull request
Jan 30, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail
pushed a commit
that referenced
this pull request
Feb 3, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail
pushed a commit
that referenced
this pull request
Feb 6, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail
pushed a commit
that referenced
this pull request
Feb 10, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail
pushed a commit
that referenced
this pull request
Feb 11, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail
pushed a commit
that referenced
this pull request
Feb 12, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail
pushed a commit
that referenced
this pull request
Feb 13, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail
pushed a commit
that referenced
this pull request
Feb 27, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Before
Pre-fix
Post-fix
Screen recording
Screen.Recording.2025-12-11.at.1.34.09.PM.mov