ROX-32848: Add grafana dashboards for rate-limiting#18279
ROX-32848: Add grafana dashboards for rate-limiting#18279
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
|
Images are ready for the commit at 13ad84b. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18279 +/- ##
=======================================
Coverage 49.68% 49.68%
=======================================
Files 2700 2700
Lines 203278 203278
=======================================
+ Hits 100999 101001 +2
+ Misses 94753 94752 -1
+ Partials 7526 7525 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ff837d0 to
c33e355
Compare
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- In
TestShutdown, thesuite.Failfcall in theRetryCommandselect branch passes a format string without placeholders and a separate "rid=%s" string, so the failure message won’t include theridvalue as intended; update it to something likesuite.Failf("Expected channel to be closed or empty, got value rid=%s", rid). - For the new
UnconfirmedMessageHandlerImpl.Stopped()/cleanup behavior, consider explicitly documenting the ordering guarantees (e.g., that all timers are stopped and channels are closed beforeStopped()is reported) to make it clear to future callers how safe it is to perform operations concurrently with shutdown.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `TestShutdown`, the `suite.Failf` call in the `RetryCommand` select branch passes a format string without placeholders and a separate "rid=%s" string, so the failure message won’t include the `rid` value as intended; update it to something like `suite.Failf("Expected channel to be closed or empty, got value rid=%s", rid)`.
- For the new `UnconfirmedMessageHandlerImpl.Stopped()`/cleanup behavior, consider explicitly documenting the ordering guarantees (e.g., that all timers are stopped and channels are closed before `Stopped()` is reported) to make it clear to future callers how safe it is to perform operations concurrently with shutdown.
## Individual Comments
### Comment 1
<location> `pkg/retry/handler/unconfirmed_message_handler_test.go:181-190` </location>
<code_context>
- // Non-blocking notify of ACK
+ // Non-blocking notify of ACK (channel may be closed if handler stopped)
select {
case <-h.ctx.Done():
return
</code_context>
<issue_to_address>
**issue (bug_risk):** Fix `Failf` formatting so the resource ID is actually included in the failure message
`Failf` uses its first argument as the format string, so in your current code the `
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| select { | ||
| case rid := <-umh.RetryCommand(): | ||
| suite.Failf("Retry channel should be drained: got %s", rid) | ||
| case <-time.After(2 * baseInterval): | ||
| case <-umh.Stopped().Done(): | ||
| // Cleanup complete | ||
| case <-time.After(time.Second): | ||
| suite.Fail("Cleanup should complete within timeout") | ||
| } | ||
|
|
||
| // After shutdown, retryCommand channel should be closed (receive returns zero value, ok=false) | ||
| select { | ||
| case rid, ok := <-umh.RetryCommand(): |
There was a problem hiding this comment.
issue (bug_risk): Fix Failf formatting so the resource ID is actually included in the failure message
Failf uses its first argument as the format string, so in your current code the `
e364d81 to
18cfffb
Compare
d69f9f0 to
1893f9b
Compare
18cfffb to
ed4dee5
Compare
59d02f9 to
b9d3498
Compare
ed4dee5 to
1d7e8b4
Compare
1d7e8b4 to
d11f34d
Compare
cd0f70d to
4ed566f
Compare
d11f34d to
5b40988
Compare
4ed566f to
765b879
Compare
5b40988 to
c337d64
Compare
765b879 to
e929947
Compare
c337d64 to
77c3806
Compare
e929947 to
77ea3b5
Compare
77c3806 to
6266793
Compare
77ea3b5 to
d866337
Compare
6266793 to
4a7ea64
Compare
d866337 to
d2bb482
Compare
4a7ea64 to
d6796fb
Compare
d2bb482 to
a17fa0f
Compare
d6796fb to
540bc17
Compare
0ba979b to
75c06b8
Compare
75c06b8 to
b1e2904
Compare
b1e2904 to
642eab6
Compare
c3b7da9 to
b2bcd0d
Compare
642eab6 to
91c8866
Compare
91c8866 to
2aa9bdf
Compare
2aa9bdf to
13ad84b
Compare
Add grafana dashboard
Place all VMVM dashboards in the same folder
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!