Skip to content

ROX-32848: Add grafana dashboards for rate-limiting#18279

Draft
vikin91 wants to merge 3 commits intomasterfrom
piotr/ROX-32316-grafana-dashboards
Draft

ROX-32848: Add grafana dashboards for rate-limiting#18279
vikin91 wants to merge 3 commits intomasterfrom
piotr/ROX-32316-grafana-dashboards

Conversation

@vikin91
Copy link
Contributor

@vikin91 vikin91 commented Dec 18, 2025

Add grafana dashboard

Place all VMVM dashboards in the same folder

Description

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@vikin91
Copy link
Contributor Author

vikin91 commented Dec 18, 2025

@openshift-ci
Copy link

openshift-ci bot commented Dec 18, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Dec 18, 2025

Images are ready for the commit at 13ad84b.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-312-g13ad84b857.

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.68%. Comparing base (52688db) to head (13ad84b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #18279   +/-   ##
=======================================
  Coverage   49.68%   49.68%           
=======================================
  Files        2700     2700           
  Lines      203278   203278           
=======================================
+ Hits       100999   101001    +2     
+ Misses      94753    94752    -1     
+ Partials     7526     7525    -1     
Flag Coverage Δ
go-unit-tests 49.68% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • In TestShutdown, the suite.Failf call in the RetryCommand select branch passes a format string without placeholders and a separate "rid=%s" string, so the failure message won’t include the rid value as intended; update it to something like suite.Failf("Expected channel to be closed or empty, got value rid=%s", rid).
  • For the new UnconfirmedMessageHandlerImpl.Stopped()/cleanup behavior, consider explicitly documenting the ordering guarantees (e.g., that all timers are stopped and channels are closed before Stopped() is reported) to make it clear to future callers how safe it is to perform operations concurrently with shutdown.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `TestShutdown`, the `suite.Failf` call in the `RetryCommand` select branch passes a format string without placeholders and a separate "rid=%s" string, so the failure message won’t include the `rid` value as intended; update it to something like `suite.Failf("Expected channel to be closed or empty, got value rid=%s", rid)`.
- For the new `UnconfirmedMessageHandlerImpl.Stopped()`/cleanup behavior, consider explicitly documenting the ordering guarantees (e.g., that all timers are stopped and channels are closed before `Stopped()` is reported) to make it clear to future callers how safe it is to perform operations concurrently with shutdown.

## Individual Comments

### Comment 1
<location> `pkg/retry/handler/unconfirmed_message_handler_test.go:181-190` </location>
<code_context>

-	// Non-blocking notify of ACK
+	// Non-blocking notify of ACK (channel may be closed if handler stopped)
 	select {
 	case <-h.ctx.Done():
 		return
</code_context>

<issue_to_address>
**issue (bug_risk):** Fix `Failf` formatting so the resource ID is actually included in the failure message

`Failf` uses its first argument as the format string, so in your current code the `
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +181 to +190
select {
case rid := <-umh.RetryCommand():
suite.Failf("Retry channel should be drained: got %s", rid)
case <-time.After(2 * baseInterval):
case <-umh.Stopped().Done():
// Cleanup complete
case <-time.After(time.Second):
suite.Fail("Cleanup should complete within timeout")
}

// After shutdown, retryCommand channel should be closed (receive returns zero value, ok=false)
select {
case rid, ok := <-umh.RetryCommand():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Fix Failf formatting so the resource ID is actually included in the failure message

Failf uses its first argument as the format string, so in your current code the `

@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from e364d81 to 18cfffb Compare December 18, 2025 11:16
@vikin91 vikin91 force-pushed the piotr/ROX-32316-compliance-retry-logic branch from d69f9f0 to 1893f9b Compare December 18, 2025 11:16
@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from 18cfffb to ed4dee5 Compare December 18, 2025 11:16
@vikin91 vikin91 force-pushed the piotr/ROX-32316-compliance-retry-logic branch from 59d02f9 to b9d3498 Compare December 18, 2025 11:33
@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from ed4dee5 to 1d7e8b4 Compare December 18, 2025 11:33
@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from 1d7e8b4 to d11f34d Compare December 19, 2025 11:04
@vikin91 vikin91 force-pushed the piotr/ROX-32316-compliance-retry-logic branch from cd0f70d to 4ed566f Compare January 2, 2026 14:29
@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from d11f34d to 5b40988 Compare January 2, 2026 14:29
@vikin91 vikin91 force-pushed the piotr/ROX-32316-compliance-retry-logic branch from 4ed566f to 765b879 Compare January 6, 2026 11:03
@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from 5b40988 to c337d64 Compare January 6, 2026 11:03
@vikin91 vikin91 force-pushed the piotr/ROX-32316-compliance-retry-logic branch from 765b879 to e929947 Compare January 7, 2026 16:04
@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from c337d64 to 77c3806 Compare January 7, 2026 16:04
@vikin91 vikin91 force-pushed the piotr/ROX-32316-compliance-retry-logic branch from e929947 to 77ea3b5 Compare January 7, 2026 16:08
@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from 77c3806 to 6266793 Compare January 7, 2026 16:08
@vikin91 vikin91 force-pushed the piotr/ROX-32316-compliance-retry-logic branch from 77ea3b5 to d866337 Compare January 8, 2026 16:57
@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from 6266793 to 4a7ea64 Compare January 8, 2026 16:57
@vikin91 vikin91 force-pushed the piotr/ROX-32316-compliance-retry-logic branch from d866337 to d2bb482 Compare January 9, 2026 16:19
@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from 4a7ea64 to d6796fb Compare January 9, 2026 16:25
@vikin91 vikin91 force-pushed the piotr/ROX-32316-compliance-retry-logic branch from d2bb482 to a17fa0f Compare January 13, 2026 15:25
@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from d6796fb to 540bc17 Compare January 13, 2026 15:26
@vikin91 vikin91 changed the base branch from piotr/ROX-32316-compliance-retry-logic to master January 14, 2026 09:48
@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from 0ba979b to 75c06b8 Compare January 14, 2026 09:48
@vikin91 vikin91 changed the base branch from master to piotr/ROX-32316-compliance-retry-logic January 14, 2026 09:51
@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from 75c06b8 to b1e2904 Compare January 14, 2026 09:51
@vikin91 vikin91 changed the base branch from piotr/ROX-32316-compliance-retry-logic to piotr/ROX-32316-central-rate-limiter January 14, 2026 10:58
@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from b1e2904 to 642eab6 Compare January 14, 2026 10:58
@vikin91 vikin91 force-pushed the piotr/ROX-32316-central-rate-limiter branch 2 times, most recently from c3b7da9 to b2bcd0d Compare January 20, 2026 16:08
Base automatically changed from piotr/ROX-32316-central-rate-limiter to master January 21, 2026 15:45
@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from 642eab6 to 91c8866 Compare January 23, 2026 08:25
@vikin91 vikin91 changed the title ROX-32316: Add grafana dashboards for rate-limiting ROX-32848: Add grafana dashboards for rate-limiting Jan 28, 2026
@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from 91c8866 to 2aa9bdf Compare March 3, 2026 14:36
@vikin91 vikin91 force-pushed the piotr/ROX-32316-grafana-dashboards branch from 2aa9bdf to 13ad84b Compare March 12, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants