stackrox · sachaudh · Jan 12, 2026 · Jan 8, 2026
@@ -27,7 +27,7 @@ function CheckboxSelect({
     const [isOpen, setIsOpen] = useState(false);
 
     const onToggleClick = () => {
-        setIsOpen(!isOpen);
+        setIsOpen((prev) => !prev);
     };
 
     const onSelect = (

@@ -11,7 +11,7 @@ const CollapsibleRow = ({ header, isCollapsible, children, isCollapsibleOpen, ha
         if (!isCollapsible) {
             return;
         }
-        setOpen(!open);
+        setOpen((prev) => !prev);
     }
 
     const icons = {

@@ -20,7 +20,7 @@ const CollapsibleSection = ({
     const [isOpen, setIsOpen] = useState(defaultOpen);
 
     function toggleOpen() {
-        setIsOpen(!isOpen);
+        setIsOpen((prev) => !prev);
     }
 
     const Icon = isOpen ? (

@@ -157,7 +157,7 @@ function AutocompleteSelect({
     );
 
     const onToggleClick = () => {
-        setIsOpen(!isOpen);
+        setIsOpen((prev) => !prev);
     };
 
     const onSelect = (

@@ -95,7 +95,7 @@ function SearchFilterConditionText({ attribute, onSearch }: SearchFilterConditio
     const [isOpen, setIsOpen] = useState(false);
 
     const onToggleClick = () => {
-        setIsOpen(!isOpen);
+        setIsOpen((prev) => !prev);
     };
 
     const onSelect = (

@@ -25,7 +25,7 @@ function SimpleSelect({
     const [isOpen, setIsOpen] = useState(false);
 
     const onToggleClick = () => {
-        setIsOpen(!isOpen);
+        setIsOpen((prev) => !prev);
     };
 
     const onSelect = (

@@ -100,7 +100,7 @@ function CheckboxSelect({
     const selectRef = useRef<HTMLDivElement>(null);
 
     function onToggle() {
-        setIsOpen(!isOpen);
+        setIsOpen((prev) => !prev);
     }
 
     function handleBlur(event: FocusEvent<HTMLDivElement>) {

@@ -40,7 +40,7 @@ function MenuDropdown({
     const [isOpen, setIsOpen] = useState(false);
 
     function onToggleClick() {
-        setIsOpen(!isOpen);
+        setIsOpen((prev) => !prev);
     }
 
     function onSelectHandler(

@@ -25,7 +25,7 @@ function PartialReportModal({ failedClusters = [], onDownload }: PartialReportMo
     const [perPage, setPerPage] = useState(20);
 
     const handleModalToggle = () => {
-        setIsModalOpen(!isModalOpen);
+        setIsModalOpen((prev) => !prev);
     };
 
     const startIndex = (page - 1) * perPage;

@@ -15,7 +15,7 @@ function useSelectToggleState(onSelectionChange: (value: string) => void) {
     };
 
     const onToggle = () => {
-        setIsOpen(!isOpen);
+        setIsOpen((prev) => !prev);
     };
 
     return {

@@ -76,7 +76,7 @@ function TypeaheadSelect({
     }
 
     function onToggle() {
-        setIsOpen(!isOpen);
+        setIsOpen((prev) => !prev);
     }
 
     function onInputChange(_event: FormEvent<HTMLInputElement>, text: string) {

@@ -172,14 +172,14 @@ function ListeningEndpointsPage() {
         <MenuToggle
             ref={toggleRef}
             variant="typeahead"
-            onClick={() => setAutocompleteOpen(!autocompleteOpen)}
+            onClick={() => setAutocompleteOpen((prev) => !prev)}
             isExpanded={autocompleteOpen}
             isFullWidth
         >
             <TextInputGroup isPlain>
                 <TextInputGroupMain
                     value={autocompleteInputValue}
-                    onClick={() => setAutocompleteOpen(!autocompleteOpen)}
+                    onClick={() => setAutocompleteOpen((prev) => !prev)}
                     onChange={(_event, value) => {
                         setAutocompleteInputValue(value);
                         updateSearchValue(value);

@@ -73,7 +73,7 @@ function ListeningEndpointsTable({
                             // TODO Awkward type assertion here is fixed in PF 5 https://github.com/patternfly/patternfly-react/issues/8330
                             collapseAllAriaLabel: 'Expand or collapse all rows' as '',
                             onToggle: () => {
-                                setAllRowsExpanded(!areAllRowsExpanded);
+                                setAllRowsExpanded((prev) => !prev);
                                 invertedExpansionRowSet.clear();
                             },
                         }}

@@ -265,7 +265,7 @@ function ClusterPage({ clusterId }: ClusterPageProps): ReactElement {
     }
 
     function toggleSA() {
-        setCreateUpgraderSA(!createUpgraderSA);
+        setCreateUpgraderSA((prev) => !prev);
     }
 
     function onDownload() {

@@ -63,7 +63,7 @@ function DelegatedScanningSettings({
                             <MenuToggle
                                 aria-label="Select default cluster"
                                 ref={toggleRef}
-                                onClick={() => setIsOpen(!isOpen)}
+                                onClick={() => setIsOpen((prev) => !prev)}
                                 isDisabled={!isEditing}
                                 isExpanded={isOpen}
                             >

@@ -36,7 +36,7 @@ function ScanConfigurationSelect({
     const [isOpen, setIsOpen] = useState(false);
 
     const onToggleClick = () => {
-        setIsOpen(!isOpen);
+        setIsOpen((prev) => !prev);
     };
 
     const onSelect = (

@@ -281,7 +281,7 @@ function NetworkGraphPageContent() {
             });
         }
 
-        setIsCIDRBlockFormOpen(!isCIDRBlockFormOpen);
+        setIsCIDRBlockFormOpen((prev) => !prev);
     }
 
     return (

@@ -26,7 +26,7 @@ function DefaultCIDRToggle({ updateNetworkNodes = () => {} }): ReactElement {
     function toggleHandler(): void {
         setHideDefaultExternalSrcs(showDefaultExternalSrcs)
             .then(() => {
-                setShowDefaultExternalSrcs(!showDefaultExternalSrcs);
+                setShowDefaultExternalSrcs((prev) => !prev);
                 setErrorMessage('');
                 updateNetworkNodes();
             })

@@ -46,7 +46,7 @@ function NotifyYAMLModal({
     function onClose() {
         onClearAll();
         setErrorMessage(null);
-        setIsModalOpen(!isModalOpen);
+        setIsModalOpen((prev) => !prev);
     }
 
     let content: ReactElement = <div />;

@@ -34,7 +34,7 @@ function PolicyCategoriesSelectField(): ReactElement {
     const selectedCategories: string[] = (field.value as string[]) ?? [];
 
     const onToggle = () => {
-        setIsOpen(!isOpen);
+        setIsOpen((prev) => !prev);
     };
 
     const onSelect = (

@@ -186,7 +186,7 @@ function PolicyCriteriaModal({
             <ModalBoxBody>
                 <Flex direction={{ default: 'column' }}>
                     <FlexItem>
-                        <Button variant="link" onClick={() => setAllExpanded(!allExpanded)}>
+                        <Button variant="link" onClick={() => setAllExpanded((prev) => !prev)}>
                             {allExpanded && 'Collapse all'}
                             {!allExpanded && 'Expand all'}
                         </Button>

@@ -68,7 +68,7 @@ function PolicySection({ sectionIndex, descriptors, readOnly = false }: PolicySe
                                     <Button
                                         variant="plain"
                                         className="pf-v5-u-px-sm"
-                                        onClick={() => setIsEditingName(!isEditingName)}
+                                        onClick={() => setIsEditingName((prev) => !prev)}
                                         title={
                                             isEditingName
                                                 ? 'Save name of policy section'

@@ -226,7 +226,7 @@ function PolicyScopeForm(): ReactElement {
                                 <MenuToggle
                                     variant="typeahead"
                                     aria-label="Typeahead menu toggle"
-                                    onClick={() => setIsExcludeImagesOpen(!isExcludeImagesOpen)}
+                                    onClick={() => setIsExcludeImagesOpen((prev) => !prev)}
                                     innerRef={toggleRef}
                                     isExpanded={isExcludeImagesOpen}
                                     isDisabled={
@@ -239,9 +239,7 @@ function PolicyScopeForm(): ReactElement {
                                     <TextInputGroup isPlain>
                                         <TextInputGroupMain
                                             value={filterValue}
-                                            onClick={() =>
-                                                setIsExcludeImagesOpen(!isExcludeImagesOpen)
-                                            }
+                                            onClick={() => setIsExcludeImagesOpen((prev) => !prev)}
                                             onChange={(_event, value) => setFilterValue(value)}
                                             autoComplete="off"
                                             placeholder="Select images to exclude"

@@ -120,7 +120,7 @@ function ReviewPolicyForm({
                         >
                             <Button
                                 variant="secondary"
-                                onClick={() => setShowPolicyResults(!showPolicyResults)}
+                                onClick={() => setShowPolicyResults((prev) => !prev)}
                             >
                                 Preview policy violations
                             </Button>

@@ -69,7 +69,7 @@ function DiagnosticBundleForm({
     }, [hasReadAccessForCluster]);
 
     function toggleClusterSelect() {
-        setClusterSelectOpen(!clusterSelectOpen);
+        setClusterSelectOpen((prev) => !prev);
     }
 
     function onSelect(_event: ReactMouseEvent | undefined, selection: string | number | undefined) {

@@ -28,7 +28,7 @@ function K8sCard({ message, keyValueAttrs = { attrs: [] }, time }: K8sCardProps)
     const [isExpanded, setIsExpanded] = useState(true);
 
     function onExpand() {
-        setIsExpanded(!isExpanded);
+        setIsExpanded((prev) => !prev);
     }
 
     return (

@@ -23,7 +23,7 @@ function NetworkFlowCard({ networkFlowInfo, message, time }: NetworkFlowCardProp
     const [isExpanded, setIsExpanded] = useState(true);
 
     function onExpand() {
-        setIsExpanded(!isExpanded);
+        setIsExpanded((prev) => !prev);
     }
 
     return (

@@ -31,7 +31,7 @@ function TimestampedEventCard<T>({
     const [isExpanded, setIsExpanded] = useState(true);
 
     function onExpand() {
-        setIsExpanded(!isExpanded);
+        setIsExpanded((prev) => !prev);
     }
 
     const timestamps = events

@@ -148,7 +148,7 @@ function ViolationsTablePanel({
     );
 
     function onToggleSelect() {
-        setIsSelectOpen(!isSelectOpen);
+        setIsSelectOpen((prev) => !prev);
     }
 
     // Handle setting confirmation modals for bulk actions

@@ -154,7 +154,7 @@ function CollectionSelection({
     }
 
     function onToggleClick() {
-        setIsOpen(!isOpen);
+        setIsOpen((prev) => !prev);
         if (isOpen) {
             setSearch('');
         }

@@ -11,7 +11,7 @@ function CreateReportDropdown({ onSelect }: CreateReportDropdownProps) {
     const [isOpen, setIsOpen] = useState(false);
 
     const onToggleClick = () => {
-        setIsOpen(!isOpen);
+        setIsOpen((prev) => !prev);
     };
 
     const onSelectHandler = (

@@ -52,7 +52,7 @@ function DefaultFilterModal({ defaultFilters, setLocalStorage }: DefaultFilterMo
         if (isOpen) {
             setValues(defaultFilters).catch(() => {});
         }
-        setIsOpen(!isOpen);
+        setIsOpen((prev) => !prev);
     }
 
     function handleSeverityChange(severity: VulnerabilitySeverityLabel, isChecked: boolean) {

@@ -35,7 +35,7 @@ interface SelectToggleReturn {
  */
 function useSelectToggle(defaultExpanded = false): SelectToggleReturn {
     const [isOpen, setIsOpen] = useState<boolean>(defaultExpanded);
-    const onToggle = useCallback(() => setIsOpen(!isOpen), [isOpen, setIsOpen]);
+    const onToggle = useCallback(() => setIsOpen((prev) => !prev), [setIsOpen]);
     const toggleSelect = useCallback(setIsOpen, [setIsOpen]);
     const openSelect = useCallback(() => toggleSelect(true), [toggleSelect]);
     const closeSelect = useCallback(() => toggleSelect(false), [toggleSelect]);

@@ -16,7 +16,7 @@ function useMultiSelect(
     const [isOpen, setIsOpen] = useState(false);
 
     function onToggle() {
-        setIsOpen(!isOpen);
+        setIsOpen((prev) => !prev);
     }
 
     function onSelect(_event, selection) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -281,7 +281,7 @@ function NetworkGraphPageContent() { @@
                 });
             }
-            setIsCIDRBlockFormOpen(!isCIDRBlockFormOpen);
+            setIsCIDRBlockFormOpen((prev) => !prev);
         }
         return (
@@ Expand Down @@