ROX-32671: Render CompoundSearchFilterLabels in virtual machines #18529
+28
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Images are ready for the commit at 29bb564. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18529 +/- ##
=======================================
Coverage 49.01% 49.01%
=======================================
Files 2641 2641
Lines 198684 198684
=======================================
Hits 97379 97379
+ Misses 93882 93881 -1
- Partials 7423 7424 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Objective: Use search filter config plus separate attributes as single source of truth.
Bomus: Render
LabelandLabelGroupinstead of deprecatedChipandChipGroupelements.Analysis
ComponentScannableStatusDropdownsearch filter element.filterChipGroupDescriptorsandfilterChipLabelof corresponding attributes.Solution
Edit VirtualMachinePageComponents.tsx file.
SearchFilterChipswithCompoundSearchFilterLabelselement.ComponentScannableStatusDropdownelement withattributeForScannabledeclaration.Delete ComponentScannableStatusDropdown.tsx file.
Residue
Investigate cost and benefit to align query string in page address with request.
Does it follow pattern of
'FIXABLE'in WorkloadCVEs folder?'SCANNABLE'in ALL CAPS'Scanned'and'Not scanned'instead of'true'and'false'User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.npm run startin ui/apps/platform folder with test instance as central.Manual testing
TODO collaborate with Brad