feat(env): Add FloatSetting with validations#18596
Merged
Conversation
Add FloatSetting with validation and format parsing tests to mirror IntegerSetting behavior and document unsupported b-format inputs. User request: "Implement something similar for the float setting" (plus follow-up test adjustments). AI-assisted: implementation and tests drafted by AI, reviewed/adjusted by user.
12 tasks
Contributor
|
Images are ready for the commit at 373de89. To use with deploy scripts, first |
lvalerom
approved these changes
Jan 21, 2026
Contributor
lvalerom
left a comment
There was a problem hiding this comment.
LGTM. I left a few non-blocking comments.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18596 +/- ##
==========================================
+ Coverage 49.13% 49.15% +0.02%
==========================================
Files 2651 2652 +1
Lines 199075 199206 +131
==========================================
+ Hits 97808 97913 +105
- Misses 93850 93876 +26
Partials 7417 7417
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add FloatSetting with bounds, allow-list, and finite-value validation plus unit tests for parsing and edge cases so float env vars behave consistently with IntegerSetting and invalid inputs fall back to defaults.
Sparked as an idea in this comment by @mtodor .
AI-assisted: FloatSetting implementation and initial tests were drafted by AI; test inputs and case selection were reviewed and adjusted by the user. User manually reviewed the entire code.
User-facing documentation
Testing and quality
Automated testing
How I validated my change