fix: pull platform-specific images in sensor integration tests#19016
Merged
fix: pull platform-specific images in sensor integration tests#19016
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Hard-coding
--platform linux/amd64in the workflow may limit future use on other runner architectures; consider deriving the platform from a matrix or an environment variable so the step remains portable.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Hard-coding `--platform linux/amd64` in the workflow may limit future use on other runner architectures; consider deriving the platform from a matrix or an environment variable so the step remains portable.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
2b3023b to
0b30572
Compare
User request: Fix multi-arch image loading issue in PR #18867 where Kind fails to load images with error "content digest not found" for arm64 layers. Problem: kind load docker-image uses docker save and ctr images import --all-platforms internally. When docker pull fetches multi-arch images, even with --platform flag, docker save includes manifest index references. The ctr import then fails because arm64 layers referenced in the manifest aren't present. Solution: Bypass "kind load docker-image" entirely by pulling images directly inside the Kind node using ctr. This avoids the docker save/import dance and the --all-platforms issue. Approach: 1. Use docker exec to run ctr inside the Kind node 2. Pull with --platform linux/amd64 to get only the needed variant 3. Pass quay.io credentials via --user flag to ctr This is a recommended workaround from kubernetes-sigs/kind issues #3795, #3845, and #4066, which document this as a known issue with Docker 29 and containerd. References: - kubernetes-sigs/kind#4066 - kubernetes-sigs/kind#3845 - kubernetes-sigs/kind#3795 Code changes developed with AI assistance. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
0b30572 to
3882854
Compare
Contributor
|
Images are ready for the commit at 3882854. To use with deploy scripts, first |
stehessel
approved these changes
Feb 13, 2026
This was referenced Feb 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19016 +/- ##
==========================================
- Coverage 49.52% 49.51% -0.01%
==========================================
Files 2666 2666
Lines 201181 201181
==========================================
- Hits 99629 99622 -7
- Misses 94114 94120 +6
- Partials 7438 7439 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
davdhacs
added a commit
that referenced
this pull request
Feb 17, 2026
Avoid intermediate QUAY_CREDS variable; pass secrets directly to --user like sensor integration tests do in #19016. Partially generated by AI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Same problem hit for kind in acs-fleet-manager's emailsender test: #19050 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix multi-arch image loading issue in PR #18867 where Kind fails to load images with error "content digest not found" for arm64 layers.
Problem: When docker pull fetches multi-arch images on amd64 runners, it downloads the manifest index but only pulls amd64 layers. Kind's import with --all-platforms then fails because arm64 layers weren't downloaded.
Solution: Add --platform linux/amd64 flag to docker pull to fetch only the platform-specific variant without the multi-arch manifest index. This ensures consistency between pulled layers and what Kind attempts to import.
See: