ROX-32674: Fix flaky base images delete E2E test#19137
Draft
ROX-32674: Fix flaky base images delete E2E test#19137
Conversation
Use direct tr:has() selector to avoid scrollIntoView crash on <tr> alias, and use interactAndWaitForResponses to eliminate races after mutations. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
/test gke-ui-e2e-tests |
Contributor
|
Images are ready for the commit at 279ddeb. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19137 +/- ##
==========================================
- Coverage 49.52% 49.51% -0.01%
==========================================
Files 2672 2672
Lines 201665 201665
==========================================
- Hits 99879 99861 -18
- Misses 94327 94344 +17
- Partials 7459 7460 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/test gke-ui-e2e-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a flaky E2E test in the base images delete flow.
Root cause: Cypress crashed with
$el.get(...).scrollIntoView is not a functionbecause the test stored a<tr>as an alias and Cypress tried to scroll it into view before clicking the kebab button inside it.<tr>elements don't reliably supportscrollIntoViewin all table contexts.Changes:
.parents('tr').as('targetRow')+.find(...)with a directtr:has(...)selector (consistent with other tests in the codebase)interactAndWaitForResponsesinaddBaseImageand the delete flow to wait for both the mutation and the subsequent list GET refetch, eliminating races where the next step runs before the UI has updated.should('not.exist')rather than manually clicking CloseUser-facing documentation
Testing and quality
Automated testing
How I validated my change
ROX_BASE_IMAGE_DETECTIONenabled