ROX-33295: Fix SearchImages not returning image names#19145
Open
charmik-redhat wants to merge 1 commit intomasterfrom
Open
ROX-33295: Fix SearchImages not returning image names#19145charmik-redhat wants to merge 1 commit intomasterfrom
charmik-redhat wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
Images are ready for the commit at 3fe970a. To use with deploy scripts, first |
ksurabhi91
approved these changes
Feb 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19145 +/- ##
=======================================
Coverage 49.51% 49.52%
=======================================
Files 2672 2672
Lines 201665 201665
=======================================
+ Hits 99864 99880 +16
+ Misses 94341 94330 -11
+ Partials 7460 7455 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c-du
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SearchImages function in image datastore created a query to select the ImageName, but it was not passing that query to the storage layer. This causes GlobalSearch to return images with empty names.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Namefield is populated in search results.