ROX-33316: Fix more prerequisites to upgrade ESLint 10.0.0#19167
Open
pedrottimark wants to merge 2 commits intomasterfrom
Open
ROX-33316: Fix more prerequisites to upgrade ESLint 10.0.0#19167pedrottimark wants to merge 2 commits intomasterfrom
pedrottimark wants to merge 2 commits intomasterfrom
Conversation
Contributor
|
Images are ready for the commit at e36be9f. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19167 +/- ##
==========================================
- Coverage 49.54% 49.54% -0.01%
==========================================
Files 2674 2674
Lines 201755 201755
==========================================
- Hits 99958 99950 -8
- Misses 94338 94344 +6
- Partials 7459 7461 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problems
Error: Cannot find module '@eslint/js'Add explicit
"@eslint/js": "^9.39.3"todevDependenciesbecause it will not be independenciesofeslintpackage in version 10.Could not resolve dependencyfor packages that have^9as latest supported version.Because
eslint-plugin-eslint-commentsis unmaintained, replace with maintained fork in eslint-community repository, which might be updated eventually.Here are the other packages that block the upgrade:
eslint-plugin-importeslint-plugin-jest-domeslint-plugin-reacteslint-plugin-react-hooksBonus
Update ESLint-related dependencies as much as possible.
In a few non-React files, either remove need for disable comments or move file-scope
/* eslint-enable no-console */to precede relevant code block and add/* eslint-enable no-console */to follow.This supports potential use of
'eslint-comments/disable-enable-pair'lint rule in the future.User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.