Draft
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
charttarget inoperator/Makefileuses[[ ... ]]andifwith Bash-specific syntax, but Makefiles default to/bin/sh; consider either switching the Makefile shell to Bash explicitly or using POSIX-compliant conditionals to avoid portability issues in different environments.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `chart` target in `operator/Makefile` uses `[[ ... ]]` and `if` with Bash-specific syntax, but Makefiles default to `/bin/sh`; consider either switching the Makefile shell to Bash explicitly or using POSIX-compliant conditionals to avoid portability issues in different environments.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Images are ready for the commit at 52d445c. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19179 +/- ##
==========================================
+ Coverage 49.52% 49.54% +0.01%
==========================================
Files 2671 2674 +3
Lines 201582 201755 +173
==========================================
+ Hits 99832 99955 +123
- Misses 94295 94341 +46
- Partials 7455 7459 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!