Skip to content

fix(ROX-33305): add StackRox image pull secret to qa-image-scanning-test namespace#19182

Draft
tommartensen wants to merge 1 commit intomasterfrom
tm/ROX-33305
Draft

fix(ROX-33305): add StackRox image pull secret to qa-image-scanning-test namespace#19182
tommartensen wants to merge 1 commit intomasterfrom
tm/ROX-33305

Conversation

@tommartensen
Copy link
Contributor

Image metadata from registry tests run in qa-image-scanning-test. The default service account in that namespace was never given image pull secrets; only per-deployment secrets (e.g. quay-image-scanning-test) were created for specific iterations. Call addStackroxImagePullSecret in ImageScanningTest.setupSpec() after ensuring the namespace exists so the default SA has quay and public-dockerhub secrets and can pull StackRox/Quay images when deployments do not set their own.

Partially generated by AI.

Description

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

…est namespace

Image metadata from registry tests run in qa-image-scanning-test. The
default service account in that namespace was never given image pull
secrets; only per-deployment secrets (e.g. quay-image-scanning-test)
were created for specific iterations. Call addStackroxImagePullSecret
in ImageScanningTest.setupSpec() after ensuring the namespace exists
so the default SA has quay and public-dockerhub secrets and can pull
StackRox/Quay images when deployments do not set their own.

Partially generated by AI.
@tommartensen tommartensen self-assigned this Feb 25, 2026
@tommartensen
Copy link
Contributor Author

/test help

@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tommartensen
Copy link
Contributor Author

/test gke-latest-qa-e2e-tests

@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 9546b0b.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-173-g9546b0b0bf.

@tommartensen
Copy link
Contributor Author

/test gke-latest-qa-e2e-tests

@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2026

@tommartensen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-latest-qa-e2e-tests 9546b0b link false /test gke-latest-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants