ROX-33335: adds more file activity detection metrics#19188
ROX-33335: adds more file activity detection metrics#19188
Conversation
|
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="sensor/common/filesystem/pipeline/pipeline.go" line_range="181" />
<code_context>
return
}
event := p.translate(fs)
+ if event != nil {
+ detectorMetrics.ObserveFileAccessEventReceived()
+ }
</code_context>
<issue_to_address>
**question:** Metric semantics may undercount events that are dropped by translation
This counter is only updated when `translate` returns a non‑nil event, so FACT events dropped/filtered by `translate` (e.g., unsupported/invalid) are not counted. If the metric is meant to report all raw FACT events entering the pipeline, consider incrementing it before translation, or always incrementing it and adding a separate metric for dropped/invalid events.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| return | ||
| } | ||
| event := p.translate(fs) | ||
| if event != nil { |
There was a problem hiding this comment.
question: Metric semantics may undercount events that are dropped by translation
This counter is only updated when translate returns a non‑nil event, so FACT events dropped/filtered by translate (e.g., unsupported/invalid) are not counted. If the metric is meant to report all raw FACT events entering the pipeline, consider incrementing it before translation, or always incrementing it and adding a separate metric for dropped/invalid events.
|
Images are ready for the commit at 427dfdf. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #19188 +/- ##
=======================================
Coverage 49.54% 49.55%
=======================================
Files 2674 2675 +1
Lines 201755 201842 +87
=======================================
+ Hits 99964 100017 +53
- Misses 94335 94361 +26
- Partials 7456 7464 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!