ROX-33270: Only set spec.replicas if autoscaling is disabled.#19199
Merged
ROX-33270: Only set spec.replicas if autoscaling is disabled.#19199
Conversation
4 tasks
Contributor
|
Images are ready for the commit at 1efff08. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19199 +/- ##
==========================================
- Coverage 49.56% 49.55% -0.01%
==========================================
Files 2675 2675
Lines 201820 201820
==========================================
- Hits 100023 100008 -15
- Misses 94340 94352 +12
- Partials 7457 7460 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/retest |
mclasmeier
approved these changes
Feb 25, 2026
Contributor
|
/retest |
rhacs-bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A change to our Helm templates which prevents our operator from playing ping-pong with the horizontal pod autoscaler (HPA). Don't set
spec.replicasfor deployments in case auto-scaling is enabled.This is simply one of the commits in #19194
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Rolled out into a dev cluster and observed.