Skip to content

fix: Set application in create-custom-snapshot to acs-4-10#19209

Merged
jvdm merged 2 commits intorelease-4.10from
tm/fix-snapshot-application
Feb 26, 2026
Merged

fix: Set application in create-custom-snapshot to acs-4-10#19209
jvdm merged 2 commits intorelease-4.10from
tm/fix-snapshot-application

Conversation

@tommartensen
Copy link
Contributor

@tommartensen tommartensen commented Feb 26, 2026

Description

Per https://redhat-internal.slack.com/archives/C0AB40QSUDS/p1772090245081989?thread_ts=1772057130.059989&cid=C0AB40QSUDS

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Snapshot from this PR: https://konflux-ui.apps.stone-prd-rh01.pg1f.p1.openshiftapps.com/ns/rh-acs-tenant/applications/acs-4-10/pipelineruns/create-custom-snapshot-z4t8q

$ kubectl ka get snapshot acs-4-10--4-10-0-rc-4-1-g88a5de4642--20260226t081931z -o yaml | yq '.items[0].spec.application'
acs-4-10

@tommartensen tommartensen self-assigned this Feb 26, 2026
@tommartensen tommartensen requested review from a team and rhacs-bot as code owners February 26, 2026 07:22
@github-actions github-actions bot added backport PR to backport changes from master to release branch konflux-build Run Konflux in PR. Push commit to trigger it. labels Feb 26, 2026
@rhacs-bot rhacs-bot requested a review from a team February 26, 2026 07:22
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Feb 26, 2026

Images are ready for the commit at bcaf705.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.0-rc.4-2-gbcaf7054c7.

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.38%. Comparing base (adf7e74) to head (bcaf705).
⚠️ Report is 3 commits behind head on release-4.10.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-4.10   #19209      +/-   ##
================================================
- Coverage         49.38%   49.38%   -0.01%     
================================================
  Files              2660     2660              
  Lines            200669   200669              
================================================
- Hits              99103    99092      -11     
- Misses            94125    94134       +9     
- Partials           7441     7443       +2     
Flag Coverage Δ
go-unit-tests 49.38% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. Thanks for catching this.

Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
@tommartensen
Copy link
Contributor Author

@stackrox/release-mgmt please merge this and cut another RC for preparing the stage release

@github-actions
Copy link
Contributor

/konflux-retest operator-bundle-on-push

@openshift-ci
Copy link

openshift-ci bot commented Feb 26, 2026

@tommartensen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-qa-e2e-tests bcaf705 link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jvdm jvdm changed the title Update application to acs-4-10 in create-custom-snapshot Set application in create-custom-snapshot to acs-4-10 Feb 26, 2026
@jvdm jvdm changed the title Set application in create-custom-snapshot to acs-4-10 fix: Set application in create-custom-snapshot to acs-4-10 Feb 26, 2026
@jvdm
Copy link
Contributor

jvdm commented Feb 26, 2026

/retest operator-bundle-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Feb 26, 2026
@jvdm
Copy link
Contributor

jvdm commented Feb 26, 2026

/konflux-retest create-custom-snapshot

@jvdm
Copy link
Contributor

jvdm commented Feb 26, 2026

I was going to re-run the failed Konflux operator bundle and snapshot creation to ensure the application was correct, but I just realized that I can look at the pipeline run and see the application string there:

image

I will use that as a confirmation that the PR is correct and valid, and merge this.

@jvdm jvdm merged commit 6f5c9d6 into release-4.10 Feb 26, 2026
112 of 118 checks passed
@jvdm jvdm deleted the tm/fix-snapshot-application branch February 26, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR to backport changes from master to release branch konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants