Draft
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at 501c0d5. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19211 +/- ##
==========================================
+ Coverage 49.56% 49.59% +0.02%
==========================================
Files 2675 2675
Lines 201820 201888 +68
==========================================
+ Hits 100028 100118 +90
+ Misses 94335 94302 -33
- Partials 7457 7468 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
dedupeNodeVulns, all entries with an emptyCvewill be collapsed into a single record because the map key isvuln.GetCve(); consider either skipping deduplication for empty CVE values or keying on a different stable identifier to avoid unintentionally merging unrelated vulnerabilities. - The new
Infoflog insendNodeIndexfor the new-format RHCOS branch will fire for every such node and may be noisy in larger clusters; consider downgrading this toDebugfor gating it behind a once-only log if it’s primarily for diagnostics.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `dedupeNodeVulns`, all entries with an empty `Cve` will be collapsed into a single record because the map key is `vuln.GetCve()`; consider either skipping deduplication for empty CVE values or keying on a different stable identifier to avoid unintentionally merging unrelated vulnerabilities.
- The new `Infof` log in `sendNodeIndex` for the new-format RHCOS branch will fire for every such node and may be noisy in larger clusters; consider downgrading this to `Debugf` or gating it behind a once-only log if it’s primarily for diagnostics.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!