ROX-31223: Track tailored profiles#19214
Draft
guzalv wants to merge 1 commit intomaster-base/gualvare/ROX-31229-tailored-profiles-protosfrom
Draft
ROX-31223: Track tailored profiles#19214guzalv wants to merge 1 commit intomaster-base/gualvare/ROX-31229-tailored-profiles-protosfrom
guzalv wants to merge 1 commit intomaster-base/gualvare/ROX-31229-tailored-profiles-protosfrom
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Feb 26, 2026
|
Skipping CI for Draft Pull Request. |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
ComplianceOperatorProfileV2construction for tailored profiles in the dispatcher largely duplicates the existingprotoProfilefields; consider refactoring into a shared helper so both V1 and V2 profiles stay in sync and reduce the chance of divergent behavior. - After adding
ComplianceOperatorProfileIsTailoredtooptions.go, double-check that the corresponding search mappings/indexing are wired up for this field so that queries against the new label actually filter onistailoredin Postgres.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `ComplianceOperatorProfileV2` construction for tailored profiles in the dispatcher largely duplicates the existing `protoProfile` fields; consider refactoring into a shared helper so both V1 and V2 profiles stay in sync and reduce the chance of divergent behavior.
- After adding `ComplianceOperatorProfileIsTailored` to `options.go`, double-check that the corresponding search mappings/indexing are wired up for this field so that queries against the new label actually filter on `istailored` in Postgres.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Images are ready for the commit at 25fcdc8. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master-base/gualvare/ROX-31229-tailored-profiles-protos #19214 +/- ##
==========================================================================================
Coverage ? 49.52%
==========================================================================================
Files ? 2668
Lines ? 201478
Branches ? 0
==========================================================================================
Hits ? 99782
Misses ? 94244
Partials ? 7452
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!