ROX-31776: Fix PF6 spacing in compliance coverage pages#19217
Open
sachaudh wants to merge 1 commit intosc/ROX-31777from
Open
ROX-31776: Fix PF6 spacing in compliance coverage pages#19217sachaudh wants to merge 1 commit intosc/ROX-31777from
sachaudh wants to merge 1 commit intosc/ROX-31777from
Conversation
Eliminate double-padding and inconsistent spacing across coverage pages by restructuring PageSection usage to separate edge-to-edge content (tabs, profile details) from padded content (toolbars, tables). - Split monolithic PageSections into noPadding sections for edge-to-edge content and standard-padded sections for toolbar/table areas - Remove unnecessary nested PageSection in CoveragesPage and CheckDetailsPage - Normalize padding utilities from md to lg for consistent spacing across ProfileDetailsHeader, ProfilesToggleGroup, and ScanConfigurationSelect - Add pf-v6-u-row-gap-0 overrides with comments per established pattern Partially generated by AI. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
|
Skipping CI for Draft Pull Request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## sc/ROX-31777 #19217 +/- ##
================================================
- Coverage 49.52% 49.52% -0.01%
================================================
Files 2666 2666
Lines 201181 201181
================================================
- Hits 99640 99625 -15
- Misses 94108 94119 +11
- Partials 7433 7437 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jira: ROX-31776
Fix PF6 spacing issues in compliance coverage pages after the PatternFly 6 migration.
pf-v6-u-p-mdwithpf-v6-u-p-lgto restore proper padding (PF6 changed spacing scale)pf-v6-u-row-gap-0to PageSection components to prevent unwanted vertical gaps between child elements<div>in CheckDetailsPage tab contentpy-smtopy-mdUser-facing documentation
Testing and quality
Automated testing
How I validated my change
Screenshots