ROX-33310: node info in file access violations#19223
Draft
ROX-33310: node info in file access violations#19223
Conversation
…lations Node-type violations now show Cluster Name, Cluster ID, Node Name, and Node ID in the violation detail view via a dedicated "Node" tab. The FileAccess hostname field is also surfaced in file access violation cards. Changes: - Add NodeAlert type, AlertNode type, and isNodeAlert type guard - Add hostname field to FileAccess type - Handle node alerts in ViolationDetailsPage entity name and resource type - Add Node tab with NodeOverview component for node-type violations - Show hostname in FileAccessCardContent when present Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
|
Skipping CI for Draft Pull Request. |
Match Deployment tab layout by wrapping NodeOverview in a Card with CardTitle, consistent with DeploymentTabWithout ReadAccessForDeployment pattern. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Contributor
|
Images are ready for the commit at 953508b. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19223 +/- ##
==========================================
- Coverage 49.56% 49.56% -0.01%
==========================================
Files 2675 2675
Lines 201838 201838
==========================================
- Hits 100038 100034 -4
- Misses 94343 94345 +2
- Partials 7457 7459 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jira: ROX-33310
Display cluster and node identification fields in the violation detail view for node-type file access violations.
NodeAlerttype,AlertNodetype, andisNodeAlert()type guard toalert.proto.tshostnamefield toFileAccesstype infileAccess.proto.tsViolationDetailsPagefor entity name and resource type displayNodeOverviewcomponent showing Node Name, Node ID, Cluster Name, Cluster IDFileAccessCardContentwhen presentUser-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tsc)npm run lint:fast-dev)Screenshots