Skip to content

ROX-33320: New metric counters and instrumentation to populate them i…#19242

Open
clickboo wants to merge 1 commit intomasterfrom
boo-adm-ctrl-metrics-collection
Open

ROX-33320: New metric counters and instrumentation to populate them i…#19242
clickboo wants to merge 1 commit intomasterfrom
boo-adm-ctrl-metrics-collection

Conversation

@clickboo
Copy link
Contributor

@clickboo clickboo commented Feb 27, 2026 •
edited
Loading

…n admission controller

Description

The following metrics have been introduced, and collected:

  • rox_admission_control_image_cache_operations_total -- Counter, label result (hit, miss, expired).
  • rox_admission_control_image_fetch_total -- Counter, labels source (sensor, central), status (success, timeout, error).
  • rox_admission_control_image_fetch_duration_seconds -- Histogram, labels source (sensor, central), status (success, timeout, error).
  • rox_admission_control_policyeval_review_duration_seconds -- Histogram, label result (allowed, denied, error).
  • rox_admission_control_policyeval_review_total -- Counter, label result (allowed, denied, bypassed, error).

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI only, await #19226 to be merged to test on infra cluster. However, that should not block reviews.

@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

sourcery-ai[bot]

This comment was marked as resolved.

Sign in to view

@clickboo clickboo force-pushed the boo-adm-ctrl-metrics-collection branch from 4008f3a to f919ceb Compare February 27, 2026 20:05
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Feb 27, 2026 •
edited
Loading

Images are ready for the commit at d1a1602.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-200-gd1a1602a1d.

@clickboo clickboo force-pushed the boo-adm-ctrl-metrics-collection branch from f919ceb to 7ce1127 Compare February 27, 2026 20:33
@codecov
Copy link

codecov bot commented Feb 27, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 28.30189% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.59%. Comparing base (3855061) to head (d1a1602).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
sensor/admission-control/manager/metrics.go 40.62% 19 Missing ⚠️
...r/admission-control/manager/evaluate_deploytime.go 0.00% 10 Missing ⚠️
sensor/admission-control/manager/images.go 18.18% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #19242      +/-   ##
==========================================
+ Coverage   49.56%   49.59%   +0.03%     
==========================================
  Files        2675     2677       +2     
  Lines      201838   201973     +135     
==========================================
+ Hits       100032   100171     +139     
+ Misses      94348    94338      -10     
- Partials     7458     7464       +6
Flag Coverage Δ
go-unit-tests 49.59% <28.30%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clickboo
Copy link
Contributor Author

clickboo commented Feb 28, 2026

/test all

@clickboo clickboo force-pushed the boo-adm-ctrl-metrics-collection branch from 7ce1127 to d1a1602 Compare February 28, 2026 09:25
@clickboo clickboo marked this pull request as ready for review February 28, 2026 10:15
@clickboo clickboo requested a review from a team as a code owner February 28, 2026 10:15
sourcery-ai[bot]

This comment was marked as outdated.

Sign in to view

@clickboo
Copy link
Contributor Author

clickboo commented Feb 28, 2026

/test gke-upgrade-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ai-review area/admission-controller area/sensor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clickboo @rhacs-bot