ROX-26420: Add migration to delete v1 report configs#19243
Draft
ksurabhi91 wants to merge 2 commits intomasterfrom
Draft
ROX-26420: Add migration to delete v1 report configs#19243ksurabhi91 wants to merge 2 commits intomasterfrom
ksurabhi91 wants to merge 2 commits intomasterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at 7f74050. To use with deploy scripts, first |
850ab9f to
7c47236
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19243 +/- ##
=======================================
Coverage 49.60% 49.61%
=======================================
Files 2676 2678 +2
Lines 201921 201941 +20
=======================================
+ Hits 100169 100185 +16
- Misses 94291 94292 +1
- Partials 7461 7464 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7c47236 to
7f74050
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a migration to delete v1 report configs since 4.1 is not longer supported and customers wont roll back to 4.1. V1 report configs are in the database in the backend but not visible in UI but they can refer to collections. In this case customers are unable to delete collections . Removing deprecated v1 config will fix this problem.
report config version is used to filter configs which will be deleted.
0 refers v1 report configs not migrated to v2
1 refers to migrated report config
2 refers to v2 report configs
This is explained in the report config proto https://github.com/stackrox/stackrox/blob/master/proto/storage/report_configuration.proto
Automated testing
How I validated my change
Fix is verified with integration tests and following upgrade tests
3.create v2 report configs