Skip to content

Fix sac for DeleteByQueryWithIDs#19244

Draft
JoukoVirtanen wants to merge 10 commits intomasterfrom
jv-fix-sac-for-DeleteByQueryWithIDs
Draft

Fix sac for DeleteByQueryWithIDs#19244
JoukoVirtanen wants to merge 10 commits intomasterfrom
jv-fix-sac-for-DeleteByQueryWithIDs

Conversation

@JoukoVirtanen
Copy link
Contributor

Description

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@openshift-ci
Copy link

openshift-ci bot commented Feb 28, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 7aa7bae.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-164-g7aa7bae8ae.

@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

❌ Patch coverage is 91.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.63%. Comparing base (2631485) to head (7aa7bae).
⚠️ Report is 52 commits behind head on master.

Files with missing lines Patch % Lines
...ntral/processindicator/datastore/datastore_impl.go 82.35% 2 Missing and 1 partial ⚠️
central/detection/lifecycle/manager_impl.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19244      +/-   ##
==========================================
+ Coverage   49.51%   49.63%   +0.11%     
==========================================
  Files        2672     2677       +5     
  Lines      201665   202058     +393     
==========================================
+ Hits        99864   100282     +418     
+ Misses      94341    94307      -34     
- Partials     7460     7469       +9     
Flag Coverage Δ
go-unit-tests 49.63% <91.66%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants