ROX-33308: Add process criteria to node event policies#19252
Open
ROX-33308: Add process criteria to node event policies#19252
Conversation
|
Skipping CI for Draft Pull Request. |
0d98d45 to
0a478bb
Compare
Contributor
|
Images are ready for the commit at a352397. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19252 +/- ##
==========================================
- Coverage 49.68% 49.68% -0.01%
==========================================
Files 2695 2695
Lines 202798 202798
==========================================
- Hits 100757 100756 -1
Misses 94527 94527
- Partials 7514 7515 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/test gke-ui-e2e-tests |
dvail
reviewed
Mar 3, 2026
ui/apps/platform/src/Containers/Policies/Wizard/Step3/policyCriteriaValidators.ts
Outdated
Show resolved
Hide resolved
2cb5231 to
c1557db
Compare
Process Name, Process Ancestor, Process Arguments, and Process UID are now available as criteria when creating Node event policies. A section validator enforces that process criteria cannot be used without File Path, since detection is driven by file access events and process info is metadata on those events. Backend support (ROX-30807, ROX-33000) must register these process fields for NODE_EVENT before the criteria will function end-to-end. Partially generated by AI. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
The 4 process criteria descriptors (Process Name, Process Ancestor, Process Arguments, Process UID) were duplicated identically between policyCriteriaDescriptors and nodeEventDescriptor arrays. Extract into a shared processActivityDescriptors constant and spread into both arrays to eliminate ~80 lines of duplication. Partially generated by AI Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Deployment runtime policies have a separate process event stream, so process criteria can be used in isolation. The file path requirement only applies to node policies where process details come exclusively via the file activity event stream. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
c1557db to
a352397
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jira: ROX-33308
Add Process Name, Process Ancestor, Process Arguments, and Process UID
as available criteria when creating Node event policies in the policy wizard.
Also add a section validator enforcing that process criteria require File Path,
since detection is file-access-driven and process info is metadata on those events.
nodeEventDescriptorNote: Backend support (ROX-30807, ROX-33000) must land before these
criteria function end-to-end.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run test-- 1343 passed, 2 skipped)Screenshots
Screen.Recording.2026-03-02.at.8.51.24.AM.mov