[WIP] ROX-32722: Optimize ListDeployment queries with column selection#19253
Open
[WIP] ROX-32722: Optimize ListDeployment queries with column selection#19253
Conversation
Contributor
|
Images are ready for the commit at 7733241. To use with deploy scripts, first |
8603022 to
2b92876
Compare
2b92876 to
7733241
Compare
|
@AlexVulaj: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GetManyListDeploymentsandGetListDeploymentwere fetching full serialized deployment protos and deserializing them, then extracting only 7 fields for ListDeployment responses.This PR creates a
ListDeploymentViewstruct and updates both methods to useRunSelectRequestForSchemaFnwith explicit column selection.User-facing documentation
Testing and quality
Automated testing
How I validated my change
Relying on existing unit/integration tests.