docs(ui): add lint/format check to AGENTS.md#19254
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
Style check failures were being missed because there was no explicit instruction to verify formatting after making changes. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
414da1c to
27a2c30
Compare
Contributor
|
Images are ready for the commit at 5c13832. To use with deploy scripts, first |
npx prettier --check doesn't use the project's ESLint config which includes prettier via eslint-plugin-prettier. Replace with npx eslint run from apps/platform/ where the config and plugins resolve correctly. AI-assisted Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
dvail
approved these changes
Mar 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19254 +/- ##
==========================================
- Coverage 49.64% 49.62% -0.02%
==========================================
Files 2679 2679
Lines 202130 202154 +24
==========================================
- Hits 100339 100322 -17
- Misses 94315 94355 +40
- Partials 7476 7477 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Disable import/namespace and import/no-cycle rules (same as lint:fast-dev) for per-file linting. These rules dominate lint time and skipping them keeps 1-200 files under 20s vs 2min+. AI-assisted Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Reuse existing lint:fast-dev script with -- <file> instead of raw npx eslint with inline rule overrides. Same behavior, cleaner command. AI-assisted Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Include the auto-fix variant so agents can fix lint/prettier issues automatically on changed files. AI-assisted Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add explicit instructions to
ui/AGENTS.mdto check IDE diagnostics and formatting after making changes. This prevents style check CI failures (like prettier violations) from being missed during development.User-facing documentation
Testing and quality
Automated testing
How I validated my change
Documentation-only change to AI agent instructions. No functional code affected.