Open
Conversation
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
c4a852a to
027df7d
Compare
Contributor
|
Images are ready for the commit at 027df7d. To use with deploy scripts, first |
rukletsov
approved these changes
Mar 3, 2026
|
|
||
| local line="<!subteam^S04SU9AHJ4C> There are ${curr} untriaged issues (not including ${prev} leftovers from previous duty)" | ||
| if [[ "$curr" -eq 0 && "$prev" -eq 0 ]]; then | ||
| echo "No issues to report (curr=0, prev=0), skipping message" |
Member
There was a problem hiding this comment.
I like to send controlflow messages to stderr, but I see this file doesn't do it. FWIW, I usually define
eecho() {
echo "$@" >&2
}
and use that in the file
| @@ -25,7 +25,18 @@ slack_triage_report() { | |||
| local prev | |||
| prev=$(total_issues_in_filter $prev_filter) | |||
Member
There was a problem hiding this comment.
IIUC these can be anything, not just numbers. Shall we add number validation, maybe in total_issues_in_filter() and die with a reasonable error message?
Contributor
Author
There was a problem hiding this comment.
the problem is who will look at the error then. If we pass it then we will see it immediately on slack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent noise from noop notifications about triage.
User-facing documentation
Testing and quality
Automated testing
How I validated my change