Skip to content

ROX-33176: Update repo factory used by compliance manager to use V2 image datastore#19286

Merged
charmik-redhat merged 1 commit intomasterfrom
ROX-33176/fix-compliance-scan-using-old-image-datastore
Mar 7, 2026
Merged

ROX-33176: Update repo factory used by compliance manager to use V2 image datastore#19286
charmik-redhat merged 1 commit intomasterfrom
ROX-33176/fix-compliance-scan-using-old-image-datastore

Conversation

@charmik-redhat
Copy link
Contributor

Description

The repo factory used by compliance manager used old image datastore to get images per cluster. This PR changes that to use the imageMapperDatastore that routes requests to image V2 or V1 datastores based on whether FlattenImageData is enabled or not.

User-facing documentation

  • CHANGELOG update is not needed
  • documentation is not needed

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 7f1dc87.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-232-g7f1dc87ba8.

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 49.61%. Comparing base (009726f) to head (7f1dc87).
⚠️ Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
central/compliance/data/factory.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19286   +/-   ##
=======================================
  Coverage   49.61%   49.61%           
=======================================
  Files        2680     2680           
  Lines      202195   202195           
=======================================
  Hits       100327   100327           
- Misses      94390    94391    +1     
+ Partials     7478     7477    -1     
Flag Coverage Δ
go-unit-tests 49.61% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@charmik-redhat charmik-redhat requested a review from a team March 4, 2026 17:36
@charmik-redhat charmik-redhat merged commit 7896227 into master Mar 7, 2026
92 of 94 checks passed
@charmik-redhat charmik-redhat deleted the ROX-33176/fix-compliance-scan-using-old-image-datastore branch March 7, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants