Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since xxhash is used in several core paths (process filtering, baselines, networkflow keys), please confirm that the v2 implementation produces identical hashes for your current usage (e.g., same algorithm/seed/endianness) wherever those hashes are persisted, used as identifiers, or exchanged between services, to avoid subtle compatibility issues.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since xxhash is used in several core paths (process filtering, baselines, networkflow keys), please confirm that the v2 implementation produces identical hashes for your current usage (e.g., same algorithm/seed/endianness) wherever those hashes are persisted, used as identifiers, or exchanged between services, to avoid subtle compatibility issues.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Images are ready for the commit at 6bec766. To use with deploy scripts, first |
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
For Sensor's netflow keys - this is safe as this data is kept in memory and is gone after restart. |
vikin91
left a comment
There was a problem hiding this comment.
Looks good, but let's make the CI happy regarding the jwt changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19290 +/- ##
==========================================
- Coverage 49.62% 49.62% -0.01%
==========================================
Files 2680 2680
Lines 202231 202231
==========================================
- Hits 100358 100353 -5
- Misses 94386 94390 +4
- Partials 7487 7488 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@vikin91 I removed jwt it deserves a separated PR as there are some breaking changes |
Description
v1 is not maintained we need to upgrade: cespare/xxhash@v1.1.0...v2.3.0
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI