Closed
Conversation
Try creating and destroying GKE cluster
|
Skipping CI for Draft Pull Request. |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider tightening the workflow triggers (e.g., limiting
pushto specific branches or using a required label on PRs) to avoid unintentionally creating GKE clusters on every push/PR where this test isn’t actually needed. - It may be useful to set an explicit
timeout-minuteson theupgrade-testjob to ensure that leaked or hung runs don’t keep GKE clusters alive longer than expected. - Since
INFRA_TOKENis exposed as a job-level env var, consider passing it only to the specificcreate-cluster/infractlsteps that require it to reduce the scope of the secret.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider tightening the workflow triggers (e.g., limiting `push` to specific branches or using a required label on PRs) to avoid unintentionally creating GKE clusters on every push/PR where this test isn’t actually needed.
- It may be useful to set an explicit `timeout-minutes` on the `upgrade-test` job to ensure that leaked or hung runs don’t keep GKE clusters alive longer than expected.
- Since `INFRA_TOKEN` is exposed as a job-level env var, consider passing it only to the specific `create-cluster`/`infractl` steps that require it to reduce the scope of the secret.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Images are ready for the commit at a48d0bd. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19291 +/- ##
=======================================
Coverage 49.62% 49.62%
=======================================
Files 2680 2680
Lines 202195 202214 +19
=======================================
+ Hits 100332 100346 +14
- Misses 94386 94391 +5
Partials 7477 7477
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I'll more likely proceed with #19303 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try creating and destroying GKE cluster
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!