Draft
Conversation
Try creating and destroying GKE cluster
|
Skipping CI for Draft Pull Request. |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- This workflow runs on
pull_requestand uses repository secrets (INFRA_TOKEN, Quay credentials, GCP account), which won’t be available for PRs from forks and might break those runs; consider either scoping the trigger to trusted branches or using a different event (e.g.pull_request_targetwith appropriate safety checks) for external contributors. - The
INFRA_TOKENis set as a job-level environment variable but also passed explicitly tocreate-cluster; if it isn’t used elsewhere in the job, you can remove the redundantenv: INFRA_TOKENdefinition to reduce confusion.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- This workflow runs on `pull_request` and uses repository secrets (`INFRA_TOKEN`, Quay credentials, GCP account), which won’t be available for PRs from forks and might break those runs; consider either scoping the trigger to trusted branches or using a different event (e.g. `pull_request_target` with appropriate safety checks) for external contributors.
- The `INFRA_TOKEN` is set as a job-level environment variable but also passed explicitly to `create-cluster`; if it isn’t used elsewhere in the job, you can remove the redundant `env: INFRA_TOKEN` definition to reduce confusion.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Images are ready for the commit at ac5334f. To use with deploy scripts, first |
967d0e0 to
b8038da
Compare
b8038da to
c36129d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19303 +/- ##
=======================================
Coverage 49.62% 49.62%
=======================================
Files 2680 2680
Lines 202195 202231 +36
=======================================
+ Hits 100332 100367 +35
+ Misses 94386 94379 -7
- Partials 7477 7485 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified #19291