Draft
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
push_helm_chartsfunction signature change to require three arguments will break any other existing callers; consider keeping the new parameters optional (with defaults and conditional logic) or adding a wrapper to preserve backward compatibility. - The
operator/Makefiletarget temporarily mutates thePROJECTfile in place based onROX_IMAGE_FLAVOR, which can be brittle (e.g., interrupted or parallel builds); consider generating a temporary copy ofPROJECTand pointingkubebuilderat that instead of editing and restoring the real file.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `push_helm_charts` function signature change to require three arguments will break any other existing callers; consider keeping the new parameters optional (with defaults and conditional logic) or adding a wrapper to preserve backward compatibility.
- The `operator/Makefile` target temporarily mutates the `PROJECT` file in place based on `ROX_IMAGE_FLAVOR`, which can be brittle (e.g., interrupted or parallel builds); consider generating a temporary copy of `PROJECT` and pointing `kubebuilder` at that instead of editing and restoring the real file.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Images are ready for the commit at 748e1c3. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19296 +/- ##
=======================================
Coverage 49.62% 49.62%
=======================================
Files 2680 2680
Lines 202195 202214 +19
=======================================
+ Hits 100332 100344 +12
- Misses 94386 94393 +7
Partials 7477 7477
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!