ROX-33453: Add prefetcher for gke-nongroovy-compatibility-tests#19306
Merged
ROX-33453: Add prefetcher for gke-nongroovy-compatibility-tests#19306
Conversation
Adds image prefetching support for compatibility tests to avoid Docker Hub rate limits, following the same pattern as PR #18867 for sensor integration tests. Changes: - scripts/ci/lib.sh: Add *compatibility-tests case to prefetcher start, await, and image list population functions - tests/e2e/run-compatibility.sh: Call prefetcher before deployment setup The existing tests/images-to-prefetch.txt already contains the nginx image used by compatibility tests (quay.io/rhacs-eng/qa-multi-arch:nginx-1-17-1 in tests/tls_challenge_test.go). User request: look at this PR #18867 we need to add prefetcher to gke-nongroovy-compatibility-tests Code changes developed with AI assistance. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Author
|
/test gke-compatibility |
Contributor
Author
|
/test gke-nongroovy-compatibility-tests |
janisz
commented
Mar 5, 2026
Contributor
Author
|
/test gke-nongroovy-compatibility-tests |
Adds image prefetching support for compatibility tests to avoid Docker Hub rate limits, following the same pattern as PR #18867 for sensor integration tests. Changes: - scripts/ci/lib.sh: Add *compatibility-tests case to prefetcher start, await, and image list population functions - tests/e2e/run-compatibility.sh: Call prefetcher before deployment setup - tests/yamls/multi-container-pod.yaml: Change imagePullPolicy from IfNotPresent to Never to use prefetched images The existing tests/images-to-prefetch.txt already contains the nginx and ubuntu images used by compatibility tests. The YAML file change is necessary because pods created directly from YAML don't go through the createDeploymentViaAPI code that respects IMAGE_PULL_POLICY_FOR_QUAY_IO. User request: look at this PR #18867 we need to add prefetcher to gke-nongroovy-compatibility-tests Code changes developed with AI assistance. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Author
|
/test gke-nongroovy-compatibility-tests |
Contributor
|
Images are ready for the commit at ac9bd70. To use with deploy scripts, first |
Contributor
Author
|
/test gke-nongroovy-compatibility-tests |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19306 +/- ##
==========================================
- Coverage 49.62% 49.62% -0.01%
==========================================
Files 2680 2680
Lines 202231 202231
==========================================
- Hits 100366 100363 -3
- Misses 94379 94383 +4
+ Partials 7486 7485 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@janisz: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
Author
|
/retest |
mtodor
approved these changes
Mar 5, 2026
ksurabhi91
pushed a commit
that referenced
this pull request
Mar 12, 2026
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds image prefetching support for compatibility tests to avoid Docker Hub rate limits, following the same pattern as PR #18867 and #17216.
Changes:
The existing tests/images-to-prefetch.txt already contains the nginx image used by compatibility tests (quay.io/rhacs-eng/qa-multi-arch:nginx-1-17-1 in tests/tls_challenge_test.go).
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!