Skip to content

ROX-33491: Fix image prefetch for qa e2e compatibility tests#19320

Merged
mtodor merged 1 commit intomasterfrom
mtodor/ROX-33491-fix-compatibiliy-tests
Mar 6, 2026
Merged

ROX-33491: Fix image prefetch for qa e2e compatibility tests#19320
mtodor merged 1 commit intomasterfrom
mtodor/ROX-33491-fix-compatibiliy-tests

Conversation

@mtodor
Copy link
Contributor

@mtodor mtodor commented Mar 6, 2026

Description

This issue should fix failing GKE version compatibility tests.

The problem is that we have two types of compatibility tests:

  • version (qa-e2e)
  • nongroovy

With current logic, pre-fetcher will run for both of them, but with set of images defined for nongroovy.
In that case some images are missing in qa-e2e tests.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • modified existing test setup

How I validated my change

  • triggered both compatibility test suites

@mtodor mtodor requested a review from janisz March 6, 2026 12:02
@mtodor
Copy link
Contributor Author

mtodor commented Mar 6, 2026

/test gke-nongroovy-compatibility-tests

@mtodor
Copy link
Contributor Author

mtodor commented Mar 6, 2026

/test gke-compatibility-tests

@mtodor
Copy link
Contributor Author

mtodor commented Mar 6, 2026

/test gke-version-compatibility-tests

@mtodor mtodor requested a review from porridge March 6, 2026 12:08
@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 02b462a.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-259-g02b462a8a6.

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.64%. Comparing base (5e9f675) to head (02b462a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19320      +/-   ##
==========================================
- Coverage   49.65%   49.64%   -0.01%     
==========================================
  Files        2689     2689              
  Lines      202505   202505              
==========================================
- Hits       100548   100533      -15     
- Misses      94463    94476      +13     
- Partials     7494     7496       +2     
Flag Coverage Δ
go-unit-tests 49.64% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtodor mtodor merged commit 1395a21 into master Mar 6, 2026
106 checks passed
@mtodor mtodor deleted the mtodor/ROX-33491-fix-compatibiliy-tests branch March 6, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants