Open
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new version filtering logic now uses two separate
grepinvocations and multiple pipes; consider consolidating the checks (e.g., a single regex or shell pattern match) to reduce process overhead and make the version ranges being excluded easier to read at a glance. - Instead of
"$(echo "${releases[$v]}" | xargs)"to trim whitespace, you can use shell parameter expansion (e.g.,${var## }/${var%% }or similar) to avoid spawning extra processes in this tight loop.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new version filtering logic now uses two separate `grep` invocations and multiple pipes; consider consolidating the checks (e.g., a single regex or shell pattern match) to reduce process overhead and make the version ranges being excluded easier to read at a glance.
- Instead of `"$(echo "${releases[$v]}" | xargs)"` to trim whitespace, you can use shell parameter expansion (e.g., `${var## }` / `${var%% }` or similar) to avoid spawning extra processes in this tight loop.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
daynewlee
commented
Mar 6, 2026
| # Sanity check. | ||
| if echo "$version" | grep -q '^[0-4]\.[0-3]'; then | ||
| echo >&2 "info: skipping pre-V4 tag: $version" | ||
| if echo "$version" | grep -q '^[0-3]\.'; then |
Contributor
Author
There was a problem hiding this comment.
Just to be extra cautious
jvdm
reviewed
Mar 6, 2026
Comment on lines
+43
to
+48
| if echo "$version" | grep -q '^[0-3]\.'; then | ||
| # pre-v4, skip | ||
| continue | ||
| fi | ||
| if echo "$version" | grep -qE '^4\.[0-3]\.'; then | ||
| # v4.0 - v4.3, skip |
Contributor
There was a problem hiding this comment.
Suggested change
| if echo "$version" | grep -q '^[0-3]\.'; then | |
| # pre-v4, skip | |
| continue | |
| fi | |
| if echo "$version" | grep -qE '^4\.[0-3]\.'; then | |
| # v4.0 - v4.3, skip | |
| # Validate and extract major.minor from X.Y.Z format. | |
| if [[ ! "$version" =~ ^([0-9]+)\.([0-9]+)\.[0-9]+$ ]]; then | |
| echo >&2 "error: invalid version format (expected X.Y.Z): $version" | |
| exit 2 | |
| fi | |
| major="${BASH_REMATCH[1]}" | |
| minor="${BASH_REMATCH[2]}" | |
| # Pre-V4 means: major < 4, OR (major == 4 AND minor < 4). | |
| if [[ $major -lt 4 ]]; then | |
| exit 0 # is pre-V4 | |
| fi | |
| if [[ $major -eq 4 && $minor -lt 4 ]]; then | |
| exit 0 # is pre-V4 | |
| fi |
Contributor
|
Images are ready for the commit at fa0e4fa. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19328 +/- ##
==========================================
+ Coverage 49.54% 49.66% +0.12%
==========================================
Files 2674 2689 +15
Lines 201755 202532 +777
==========================================
+ Hits 99956 100594 +638
- Misses 94340 94428 +88
- Partials 7459 7510 +51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
echo "4.11.0" | grep -oE '^4\.[0-3]\.'returns nothingUser-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!