Skip to content

ROX-33448: Set container image idv2 when merging cron jobs#19330

Open
charmik-redhat wants to merge 3 commits intomasterfrom
ROX-33448/merge-cron-jobs-does-not-set-container-image-idv2
Open

ROX-33448: Set container image idv2 when merging cron jobs#19330
charmik-redhat wants to merge 3 commits intomasterfrom
ROX-33448/merge-cron-jobs-does-not-set-container-image-idv2

Conversation

@charmik-redhat
Copy link
Contributor

@charmik-redhat charmik-redhat commented Mar 8, 2026 •
edited
Loading

Description

The mergeCronJobs func in deployment datastore sets the container image IDs of the cron jobs. When doing that, it should also set IDV2 of container images.

User-facing documentation

  • CHANGELOG update is not needed
  • documentation is not needed

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Updates unit test to verify IDV2 is set.

@openshift-ci
Copy link

openshift-ci bot commented Mar 8, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 8, 2026 •
edited
Loading

Images are ready for the commit at ddd37eb.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-234-gddd37ebebb.

@codecov
Copy link

codecov bot commented Mar 8, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.67%. Comparing base (009726f) to head (ddd37eb).
⚠️ Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
central/deployment/datastore/datastore_impl.go 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #19330      +/-   ##
==========================================
+ Coverage   49.61%   49.67%   +0.05%     
==========================================
  Files        2680     2689       +9     
  Lines      202195   202539     +344     
==========================================
+ Hits       100327   100603     +276     
- Misses      94390    94425      +35     
- Partials     7478     7511      +33
Flag Coverage Δ
go-unit-tests 49.67% <40.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@charmik-redhat charmik-redhat changed the title Set container image idv2 when merging cron jobs ROX-33448: Set container image idv2 when merging cron jobs Mar 9, 2026
@charmik-redhat charmik-redhat marked this pull request as ready for review March 9, 2026 05:21
@charmik-redhat charmik-redhat requested a review from a team March 9, 2026 05:21
@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2026

@charmik-redhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-qa-e2e-tests ddd37eb link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dashrews78 dashrews78 dashrews78 approved these changes

Assignees

No one assigned

Labels

area/central

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charmik-redhat @rhacs-bot @dashrews78