ROX-33574: Don't forget to configure scanner pull secrets#19383
ROX-33574: Don't forget to configure scanner pull secrets#19383mclasmeier wants to merge 1 commit intomasterfrom
Conversation
|
Images are ready for the commit at 985d901. To use with deploy scripts, first |
fac2083 to
b94ce02
Compare
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 28322140 | Triggered | Username Password | 985d901 | pkg/helm/charts/tests/securedclusterservices/testdata/helmtest/image-pull-secrets.test.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
when scanner V4 is disabled and only scanner V2 is being used.
b94ce02 to
985d901
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19383 +/- ##
=======================================
Coverage 49.65% 49.65%
=======================================
Files 2698 2698
Lines 203120 203132 +12
=======================================
+ Hits 100852 100864 +12
- Misses 94745 94746 +1
+ Partials 7523 7522 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
See ROX-33574. Fixes a bug in the secured-cluster Helm chart.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!