ROX-33246: add more assertions to compliance test#19393
Open
ROX-33246: add more assertions to compliance test#19393
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at f23b1c2. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19393 +/- ##
=======================================
Coverage 49.68% 49.68%
=======================================
Files 2700 2700
Lines 203278 203278
=======================================
+ Hits 100999 101006 +7
+ Misses 94753 94748 -5
+ Partials 7526 7524 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add additional assertions for
ScanSettingandScanSettingBindingtowaitForComplianceSuiteToComplete. This is to make sure these actually exist in case we encounter problems with not finding the compliance suite.I've also noticed some incorrect
NoErrorinstead ofNoErrorf, so I fixed those as well.User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI