Conversation
The compound search filter on the Violations page showed all 7 entity categories regardless of which workflow view was active, causing users to see irrelevant filter options (e.g. Node filters in Applications view). The search filter config is now driven by the active filteredWorkflowView so only contextually relevant entities appear. Additionally, switching workflow views now clears all active search filters and resets pagination to page 1, preventing orphaned filters from invisible entities from affecting query results. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
|
Skipping CI for Draft Pull Request. |
…ntity list Full view should show all entities, so use an empty array as a signal to return allSearchFilterEntities directly. This avoids maintaining a duplicate list that must be updated whenever new entities are added. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Contributor
|
Images are ready for the commit at 928e210. To use with deploy scripts, first |
Rewrite tests to verify the actual filtering behavior rather than mirroring the config values. Each view test asserts that entities irrelevant to that workflow context are excluded. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Reorder allSearchFilterEntities so the entity selector dropdown displays entries alphabetically: Cluster, Deployment, Namespace, Node, Policy, Policy violation, Resource. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19400 +/- ##
=======================================
Coverage 49.68% 49.69%
=======================================
Files 2700 2700
Lines 203278 203278
=======================================
+ Hits 100999 101009 +10
+ Misses 94753 94746 -7
+ Partials 7526 7523 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jira: ROX-33406
The compound search filter on the Violations page showed all 7 entity categories regardless of which workflow view was active. Users saw irrelevant filter options (e.g. Node filters in Applications view).
searchFilterConfigdynamic based onfilteredWorkflowViewinViolationsTableSearchFilterfilteredWorkflowViewthroughViolationsTablePaneltoViolationsTableSearchFilterUser-facing documentation
Testing and quality
Automated testing
How I validated my change
getSearchFilterConfigfor all four workflow views (Applications, Platform, Node, Full)defaultEntityprop)Screenshots