Skip to content

Fixing tiny imperfect things#19405

Open
charmik-redhat wants to merge 2 commits intomasterfrom
charmik/tiny-imperfect-things-with-imageV2
Open

Fixing tiny imperfect things#19405
charmik-redhat wants to merge 2 commits intomasterfrom
charmik/tiny-imperfect-things-with-imageV2

Conversation

@charmik-redhat
Copy link
Contributor

Description

This PR fixes some minor bugs with the image data model. Most of the things fixed are deprecated or no longer exposed in UI. The only important fix is copying over BaseImageInfo when converting between v1 and v2 images.

Note : Changes were assisted by Cursor

User-facing documentation

  • CHANGELOG update is not needed
  • documentation is not needed

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Passing CI is enough

@charmik-redhat charmik-redhat requested a review from a team as a code owner March 13, 2026 00:08
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 13, 2026

Images are ready for the commit at efa6a58.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-313-gefa6a58af7.

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 30.43478% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.68%. Comparing base (c46454a) to head (efa6a58).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
central/cve/matcher/matcher.go 38.88% 9 Missing and 2 partials ⚠️
...lityrequest/manager/querymgr/query_manager_impl.go 0.00% 3 Missing ⚠️
central/cve/matcher/singleton.go 0.00% 1 Missing ⚠️
pkg/images/types/type.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19405      +/-   ##
==========================================
- Coverage   49.68%   49.68%   -0.01%     
==========================================
  Files        2700     2700              
  Lines      203297   203326      +29     
==========================================
  Hits       101018   101018              
- Misses      94753    94780      +27     
- Partials     7526     7528       +2     
Flag Coverage Δ
go-unit-tests 49.68% <30.43%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants