Skip to content

ROX-33352: Add histogram of lineage size#19406

Open
JoukoVirtanen wants to merge 3 commits intojv-ROX-32873-metrics-for-process-argumentsfrom
jv-ROX-33352-add-histogram-of-lineage-size
Open

ROX-33352: Add histogram of lineage size#19406
JoukoVirtanen wants to merge 3 commits intojv-ROX-32873-metrics-for-process-argumentsfrom
jv-ROX-33352-add-histogram-of-lineage-size

Conversation

@JoukoVirtanen
Copy link
Contributor

@JoukoVirtanen JoukoVirtanen commented Mar 13, 2026 •
edited
Loading

Description

Adds a metric that keeps track of a histogram of the size of process lineages in characters.

See the related PR for a metric for process arguments. #18794

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

# HELP rox_central_process_indicators_lineage_size Distribution of process lineage sizes in characters for upserted indicators
# TYPE rox_central_process_indicators_lineage_size histogram 
rox_central_process_indicators_lineage_size_bucket{le="0"} 155
rox_central_process_indicators_lineage_size_bucket{le="128"} 457
rox_central_process_indicators_lineage_size_bucket{le="256"} 457 
rox_central_process_indicators_lineage_size_bucket{le="512"} 457
rox_central_process_indicators_lineage_size_bucket{le="1024"} 457
rox_central_process_indicators_lineage_size_bucket{le="2048"} 457
rox_central_process_indicators_lineage_size_bucket{le="4096"} 457
rox_central_process_indicators_lineage_size_bucket{le="8192"} 457
rox_central_process_indicators_lineage_size_bucket{le="16384"} 457
rox_central_process_indicators_lineage_size_bucket{le="32768"} 457
rox_central_process_indicators_lineage_size_bucket{le="65536"} 457
rox_central_process_indicators_lineage_size_bucket{le="+Inf"} 457 
rox_central_process_indicators_lineage_size_sum 13417
rox_central_process_indicators_lineage_size_count 457
# HELP rox_central_process_indicators_lineage_size_total Total process lineage sizes in characters by cluster and namespace
# TYPE rox_central_process_indicators_lineage_size_total counter
rox_central_process_indicators_lineage_size_total{cluster="ab949c19-54ca-4397-8fa9-955d494d9e3d",namespace="default"} 0
rox_central_process_indicators_lineage_size_total{cluster="ab949c19-54ca-4397-8fa9-955d494d9e3d",namespace="gke-managed-cim"} 0
rox_central_process_indicators_lineage_size_total{cluster="ab949c19-54ca-4397-8fa9-955d494d9e3d",namespace="gmp-system"} 0
rox_central_process_indicators_lineage_size_total{cluster="ab949c19-54ca-4397-8fa9-955d494d9e3d",namespace="kube-system"} 11562
rox_central_process_indicators_lineage_size_total{cluster="ab949c19-54ca-4397-8fa9-955d494d9e3d",namespace="stackrox"} 1855

@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@JoukoVirtanen JoukoVirtanen changed the base branch from jv-ROX-33267-metrics-to-keep-track-of-pruned-process-indicators to jv-ROX-32873-metrics-for-process-arguments March 13, 2026 00:19
@JoukoVirtanen JoukoVirtanen changed the title Jv rox 33352 add histogram of lineage size ROX-33352: Add histogram of lineage size Mar 13, 2026
@JoukoVirtanen JoukoVirtanen requested a review from erthalion March 13, 2026 02:40
@JoukoVirtanen JoukoVirtanen marked this pull request as ready for review March 13, 2026 02:40
@JoukoVirtanen JoukoVirtanen mentioned this pull request Mar 13, 2026
Open
9 tasks
@JoukoVirtanen JoukoVirtanen force-pushed the jv-ROX-33352-add-histogram-of-lineage-size branch from 213fab8 to 3139871 Compare March 13, 2026 17:36
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 13, 2026

Images are ready for the commit at 3139871.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-313-g313987106c.

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.65%. Comparing base (ccc26a8) to head (3139871).

Files with missing lines Patch % Lines
central/processindicator/datastore/metrics.go 70.00% 6 Missing ⚠️
Additional details and impacted files 
@@                              Coverage Diff                               @@
##           jv-ROX-32873-metrics-for-process-arguments   #19406      +/-   ##
==============================================================================
- Coverage                                       49.71%   49.65%   -0.07%     
==============================================================================
  Files                                            2701     2698       -3     
  Lines                                          203471   203112     -359     
==============================================================================
- Hits                                           101160   100854     -306     
+ Misses                                          94784    94738      -46     
+ Partials                                         7527     7520       -7
Flag Coverage Δ
go-unit-tests 49.65% <70.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erthalion erthalion Awaiting requested review from erthalion

Assignees

No one assigned

Labels

area/central

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoukoVirtanen @rhacs-bot