Conversation
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
|
Images are ready for the commit at aefbfb4. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19414 +/- ##
==========================================
+ Coverage 49.68% 49.71% +0.02%
==========================================
Files 2700 2701 +1
Lines 203312 203453 +141
==========================================
+ Hits 101014 101145 +131
- Misses 94772 94782 +10
Partials 7526 7526
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@janisz: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Previous refactoring changed deployments from List to Map but missed updating iteration and property access, causing test failures: - GroovyCastException: iterating Map yields Map.Entry, not Deployment - NullPointerException: Maps don't have .name property Fixes: - Use deployments.values() for iteration in destroyDeployments() - Use deployments.keySet().join() for query string construction - Add type annotations to modified lines (String, boolean) User request: Fix test failures, keep diff minimal, add types only to changed lines Partially AI-assisted.
d3ee8bc to
aefbfb4
Compare
Description
Change deployments from list to map to allow direct access instead of
findUser-facing documentation
Testing and quality
Automated testing
How I validated my change
CI