ROX-33555: Add sensor cap checks for SensorAck for node scanning#19418
Open
ROX-33555: Add sensor cap checks for SensorAck for node scanning#19418
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
11 tasks
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
recordingInjectorWithCapabilitiestype is duplicated in both nodeinventory and nodeindex tests; consider extracting a shared test helper (or extendingrecordingInjectorwith a defaultHasCapabilityimplementation) to avoid repetition and keep capability behavior consistent across tests. SendSensorACKsilently returns when the injector does not implementcapabilityChecker; if this is expected only for older/non-production injectors, consider documenting that assumption or adding a small debug log/TODO so it’s clearer when SensorACKs might be skipped due to injector type rather than capability.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `recordingInjectorWithCapabilities` type is duplicated in both nodeinventory and nodeindex tests; consider extracting a shared test helper (or extending `recordingInjector` with a default `HasCapability` implementation) to avoid repetition and keep capability behavior consistent across tests.
- `SendSensorACK` silently returns when the injector does not implement `capabilityChecker`; if this is expected only for older/non-production injectors, consider documenting that assumption or adding a small debug log/TODO so it’s clearer when SensorACKs might be skipped due to injector type rather than capability.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Images are ready for the commit at 8b9adc1. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19418 +/- ##
==========================================
- Coverage 49.71% 49.70% -0.01%
==========================================
Files 2701 2702 +1
Lines 203453 203465 +12
==========================================
- Hits 101144 101140 -4
- Misses 94782 94805 +23
+ Partials 7527 7520 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR scopes the node-scanning ACK refactor isolated from #19323.
What changed:
central/sensor/service/common/sensor_ack.gowith shared helpers to send:SensorACKNodeInventoryACK(always, for backward compatibility)nodeinventoryACK pathnodeindexACK pathBefore/after behavior example:
SensorACKfor node scanning regardless of Sensor capability.SensorACKfor node scanning only when Sensor advertisesSensorACKSupport; legacyNodeInventoryACKremains emitted for compatibility.User-facing documentation
Testing and quality
Automated testing
How I validated my change