Open
Conversation
Add read-only DataStore for VirtualMachineComponentV2, modeled after the image component v2 and image CVE v2 datastores. The singleton is gated behind the VirtualMachinesEnhancedDataModel feature flag, returning nil when disabled. Integration tests cover all DataStore methods (Search, SearchRawVMComponents, Exists, Get, Count, GetBatch) under 10 namespace-scoped SAC contexts plus denied-access and feature-flag gating scenarios. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at 655e01f. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #19433 +/- ##
==========================================
- Coverage 49.73% 49.73% -0.01%
==========================================
Files 2703 2706 +3
Lines 204040 204089 +49
==========================================
+ Hits 101489 101511 +22
- Misses 94977 94999 +22
- Partials 7574 7579 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ajheflin
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add read-only DataStore for VirtualMachineComponentV2, modeled after the
image component v2 and image CVE v2 datastores. The singleton is gated
behind the VirtualMachinesEnhancedDataModel feature flag, returning nil
when disabled.
Integration tests cover all DataStore methods (Search, SearchRawVMComponents,
Exists, Get, Count, GetBatch) under 10 namespace-scoped SAC contexts
plus denied-access and feature-flag gating scenarios.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI and new tests are sufficient. Tests were exercised manually with the feature flag on. More thorough testing will be included later when we finish wiring everything together.