Merged
Conversation
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The junit2jira version string is duplicated in both the GitHub Action and the CI script; consider centralizing the version in a single variable or script to reduce the chance of them drifting out of sync on future bumps.
- If feasible, consider adding a checksum verification for the downloaded junit2jira/flakechecker binaries to guard against tampering or partial downloads beyond curl’s retry logic.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The junit2jira version string is duplicated in both the GitHub Action and the CI script; consider centralizing the version in a single variable or script to reduce the chance of them drifting out of sync on future bumps.
- If feasible, consider adding a checksum verification for the downloaded junit2jira/flakechecker binaries to guard against tampering or partial downloads beyond curl’s retry logic.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Contributor
|
Images are ready for the commit at d20085e. To use with deploy scripts, first |
porridge
approved these changes
Mar 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19436 +/- ##
==========================================
- Coverage 49.73% 49.73% -0.01%
==========================================
Files 2703 2703
Lines 204040 204040
==========================================
- Hits 101489 101486 -3
- Misses 94977 94979 +2
- Partials 7574 7575 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jira Cloud support:
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI