fix(CI): update triage periodic to jira cloud#19442
Merged
Conversation
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
total_issues_in_filterfunction now pulls all issues (withmaxResults=5000) and counts them locally; consider either using the approximate count API you referenced or implementing pagination/maxResults=0with.totalto avoid silently truncating counts when filters exceed the chosen limit. - When invoking
total_issues_in_filter $curr_filterand$prev_filter, it’s safer to quote the filter arguments (e.g.,"$curr_filter") to avoid unexpected word splitting if the IDs are ever replaced by JQL or non-numeric values.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `total_issues_in_filter` function now pulls all issues (with `maxResults=5000`) and counts them locally; consider either using the approximate count API you referenced or implementing pagination/`maxResults=0` with `.total` to avoid silently truncating counts when filters exceed the chosen limit.
- When invoking `total_issues_in_filter $curr_filter` and `$prev_filter`, it’s safer to quote the filter arguments (e.g., `"$curr_filter"`) to avoid unexpected word splitting if the IDs are ever replaced by JQL or non-numeric values.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Images are ready for the commit at 45d2cbe. To use with deploy scripts, first |
rukletsov
approved these changes
Mar 16, 2026
Contributor
Author
|
/dog |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19442 +/- ##
==========================================
- Coverage 49.73% 49.55% -0.18%
==========================================
Files 2703 2711 +8
Lines 204040 204849 +809
==========================================
+ Hits 101482 101522 +40
- Misses 94982 95746 +764
- Partials 7576 7581 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need to upgrade to latest JIRA API. It removes searching with filter so we need to get jql for a filter and search. There is an option to get approximated search count but in our case it should be single digit so it should be fine to call the API and count objects.
User-facing documentation
Testing and quality
Automated testing
Run locally with different filters that returns some data.