ROX-33539: Hide Attempted tab in Node violations#19444
Open
ROX-33539: Hide Attempted tab in Node violations#19444
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at 79c60ca. To use with deploy scripts, first |
Node policies have no admission controller evaluation, so attempted alerts are never generated for nodes. The Attempted tab is now hidden when the Node workflow view is selected, and automatically resets to the Active tab if navigated to via URL. Fixes: ROX-33539 Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Replace imported nodeWorkflowView constant with inline string literal to simplify the Node violations Attempted tab filtering logic. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
5fe5037 to
d679b83
Compare
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19444 +/- ##
==========================================
- Coverage 49.56% 49.55% -0.01%
==========================================
Files 2711 2711
Lines 204849 204849
==========================================
- Hits 101528 101517 -11
- Misses 95741 95748 +7
- Partials 7580 7584 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jira: ROX-33539
Node policies have no admission controller evaluation, so attempted alerts are never generated for nodes. The "Attempted" tab on the Violations page is irrelevant in Node view.
useEffectto reset tab to Active if user is on Attempted tab when switching to Node view (also handles direct URL navigation)nodeWorkflowViewconstant for type-safe comparisonUser-facing documentation
Testing and quality
Automated testing
How I validated my change
Screenshots
Screen.Recording.2026-03-16.at.11.28.17.AM.mov