fix(CI): add missing jira-url for junit2jira#19453
Merged
Conversation
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The Jira base URL is now hardcoded in two places; consider centralizing it in a shared variable or configuration so that changing it in the future doesn’t require updating multiple call sites.
- For the GitHub Action, it may be more flexible to expose
jira-urlas an action input (with a default) rather than hardcoding the URL, so different environments or forks can override it if needed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The Jira base URL is now hardcoded in two places; consider centralizing it in a shared variable or configuration so that changing it in the future doesn’t require updating multiple call sites.
- For the GitHub Action, it may be more flexible to expose `jira-url` as an action input (with a default) rather than hardcoding the URL, so different environments or forks can override it if needed.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
msugakov
reviewed
Mar 17, 2026
Contributor
|
Images are ready for the commit at 771e7c7. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19453 +/- ##
==========================================
- Coverage 49.38% 49.37% -0.01%
==========================================
Files 2713 2713
Lines 204925 204925
==========================================
- Hits 101206 101190 -16
- Misses 96191 96201 +10
- Partials 7528 7534 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
porridge
approved these changes
Mar 17, 2026
Contributor
msugakov
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need to configure new Jira URL for junit2jira. The default one is working but not for all endpoints.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Old
New: