Conversation
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
retry 5 true docker exec ...invocation looks suspicious—ifretryexpects the retry count as the first argument and the command as the rest, you probably wantretry 5 docker exec ...(or whatever the expected signature is) rather than passing an extratrueargument. - Sourcing
scripts/lib.shin therunstep assumes a Bash-compatible shell; consider explicitly settingshell: bashon this step or confirming the default shell is compatible to avoid subtle failures.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `retry 5 true docker exec ...` invocation looks suspicious—if `retry` expects the retry count as the first argument and the command as the rest, you probably want `retry 5 docker exec ...` (or whatever the expected signature is) rather than passing an extra `true` argument.
- Sourcing `scripts/lib.sh` in the `run` step assumes a Bash-compatible shell; consider explicitly setting `shell: bash` on this step or confirming the default shell is compatible to avoid subtle failures.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Images are ready for the commit at 2527489. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19456 +/- ##
==========================================
- Coverage 49.37% 49.37% -0.01%
==========================================
Files 2713 2713
Lines 204977 204977
==========================================
- Hits 101207 101202 -5
- Misses 96242 96245 +3
- Partials 7528 7530 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rhybrillou
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Loading images from quay may fail, let's retry it to prevent failures.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI