ROX-33626: Add Prometheus metrics to alert manager#19459
Merged
dashrews78 merged 2 commits intomasterfrom Mar 18, 2026
Merged
Conversation
Add instrumentation to AlertAndNotify and mergeManyAlerts to collect production data on alert processing performance before optimizing. Metrics added: - alert_and_notify_duration_ms: end-to-end duration histogram - alert_and_notify_incoming_count: incoming alerts per call - merge_many_alerts_duration_ms: merge duration histogram - merge_many_alerts_previous_count: previous alerts fetched from DB - alert_outcome_total: counter vec by outcome (new/updated/resolved) Partially generated by AI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
Contributor
|
Images are ready for the commit at a634bf6. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19459 +/- ##
==========================================
- Coverage 49.34% 49.33% -0.01%
==========================================
Files 2719 2723 +4
Lines 205087 205197 +110
==========================================
+ Hits 101193 101232 +39
- Misses 96361 96435 +74
+ Partials 7533 7530 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ajheflin
reviewed
Mar 17, 2026
ajheflin
reviewed
Mar 17, 2026
Address PR feedback: extract observeDurationMs helper for the defer-based duration pattern, and move outcome counting to a plain recordAlertOutcomes call at the end of mergeManyAlerts instead of using closures over named return values. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ajheflin
approved these changes
Mar 17, 2026
AlexVulaj
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add instrumentation to AlertAndNotify and mergeManyAlerts to collect
production data on alert processing performance before optimizing.
Metrics added:
Partially generated by AI.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Spun up openshift cluster with the PR and checked the metrics in a diagnostic bundle.