ROX-33627: Add benchmarks for alert manager#19460
Open
dashrews78 wants to merge 2 commits intomasterfrom
Open
Conversation
Add sql_integration benchmarks for mergeManyAlerts and AlertAndNotify using real Postgres to measure protobuf deserialization cost and allocation pressure. These provide a baseline for the two-phase fetch optimization — results confirm merge dominates the pipeline (~80-90% at 1000 previous alerts) with ~30 allocs per previous alert. Partially generated by AI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
Contributor
|
Images are ready for the commit at 9e5ba18. To use with deploy scripts, first |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19460 +/- ##
==========================================
- Coverage 49.34% 49.33% -0.02%
==========================================
Files 2719 2722 +3
Lines 205087 205145 +58
==========================================
+ Hits 101193 101199 +6
- Misses 96361 96414 +53
+ Partials 7533 7532 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ajheflin
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add sql_integration benchmarks for mergeManyAlerts and AlertAndNotify
using real Postgres to measure protobuf deserialization cost and
allocation pressure. These provide a baseline for the two-phase fetch
optimization — results confirm merge dominates the pipeline (~80-90%
at 1000 previous alerts) with ~30 allocs per previous alert.
Partially generated by AI.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
User-facing documentation
Testing and quality
Automated testing
How I validated my change
This is just a test.